[Merged by Bors] - chore: replace continuity -> fun_prop in remaining auto-parameters#35273
Closed
grunweg wants to merge 16 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: replace continuity -> fun_prop in remaining auto-parameters#35273grunweg wants to merge 16 commits intoleanprover-community:masterfrom
continuity -> fun_prop in remaining auto-parameters#35273grunweg wants to merge 16 commits intoleanprover-community:masterfrom
Conversation
PR summary 83a9b27e0dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
aa6c640 to
d7d44fd
Compare
continuity -> fun_prop in a few more auto-parameterscontinuity -> fun_prop in remaining auto-parameters
1 task
|
This PR/issue depends on: |
Contributor
Author
|
!bench |
|
Benchmark results for 5019c09 against 3773dce are in! @grunweg
Large changes (2✅)
Medium changes (3✅)
Small changes (3✅)
|
Contributor
|
The performance gains on this look good to me! Thanks! |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
SnirBroshi
reviewed
Mar 20, 2026
| (M : Type*) [TopologicalSpace M] [AddCommMonoid M] (M₂ : Type*) [TopologicalSpace M₂] | ||
| [AddCommMonoid M₂] [Module R M] [Module S M₂] extends M →ₛₗ[σ] M₂ where | ||
| cont : Continuous toFun := by continuity | ||
| cont : Continuous toFun := by fun_prop |
Collaborator
There was a problem hiding this comment.
This seems to be failing the build, can you try merging master?
Contributor
|
bors r- |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
|
Canceled. |
Contributor
Author
|
Green - let's merge again: |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
continuity -> fun_prop in remaining auto-parameterscontinuity -> fun_prop in remaining auto-parameters
justus-springer
pushed a commit
to justus-springer/mathlib4
that referenced
this pull request
Mar 28, 2026
leanprover-community#35273) Resurrected version of leanprover-community#13994. Let's look at the current fall-out and performance effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resurrected version of #13994. Let's look at the current fall-out and performance effect.