Skip to content

[Merged by Bors] - chore: replace continuity by fun_prop in a few proofs#35278

Closed
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:more_funprop
Closed

[Merged by Bors] - chore: replace continuity by fun_prop in a few proofs#35278
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:more_funprop

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Feb 13, 2026

This includes three cases of auto-parameters that are by fun_prop now.


My motivation is performance (fun_prop tends to be faster) as well as the potential of removing (almost) all usage of continuity in mathlib.

Open in Gitpod

This includes three cases of auto-parameters that are `by fun_prop` now.
@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 13, 2026
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Feb 13, 2026

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Feb 13, 2026

Benchmark results for 339123f against 4aa0616 are in! @grunweg

  • build//instructions: -28.0G (-0.02%)

Small changes (2✅)

  • build/module/Mathlib.Topology.Homotopy.HomotopyGroup//instructions: -3.9G (-5.51%)
  • build/module/Mathlib.Topology.Homotopy.Path//instructions: -7.1G (-18.82%)

@github-actions
Copy link
Copy Markdown

PR summary 4aa0616ac5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added t-topology Topological spaces, uniform spaces, metric spaces, filters and removed awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Feb 13, 2026
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Feb 17, 2026
This includes three cases of auto-parameters that are `by fun_prop` now.
@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 17, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 17, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: replace continuity by fun_prop in a few proofs [Merged by Bors] - chore: replace continuity by fun_prop in a few proofs Feb 17, 2026
@mathlib-bors mathlib-bors bot closed this Feb 17, 2026
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
…munity#35278)

This includes three cases of auto-parameters that are `by fun_prop` now.
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
…munity#35278)

This includes three cases of auto-parameters that are `by fun_prop` now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants