Skip to content

[Merged by Bors] - feat: a lower bound for the volume of a cone on the unit sphere#31960

Closed
urkud wants to merge 16 commits intoleanprover-community:masterfrom
urkud:tosphere-bound
Closed

[Merged by Bors] - feat: a lower bound for the volume of a cone on the unit sphere#31960
urkud wants to merge 16 commits intoleanprover-community:masterfrom
urkud:tosphere-bound

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Nov 22, 2025

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 22, 2025

PR summary b9c0430677

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ toSphereBallBound
+ toSphereBallBound_mul_measureReal_unitBall_le_toSphere_ball
+ toSphereBallBound_mul_measure_unitBall_le_toSphere_ball
+ toSphereBallBound_pos

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 22, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 25, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 25, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 25, 2025
@urkud urkud added the t-measure-probability Measure theory / Probability theory label Nov 25, 2025
@urkud urkud marked this pull request as ready for review November 25, 2025 21:24
@PatrickMassot
Copy link
Copy Markdown
Member

Could you please comment on what you want to do with this lemma? It is pretty mysterious to me. Is it part of your Sard effort?

@urkud
Copy link
Copy Markdown
Member Author

urkud commented Dec 19, 2025

For Sard's Theorem, I need a weaker version of this theorem, namely that this lower bound exists for each normed space. If we decide to merge this theorem too, then we can make some intermediate estimate depend on the dimension of the domain only, but it turned out to be not necessary for the proof.

@urkud
Copy link
Copy Markdown
Member Author

urkud commented Dec 19, 2025

Here is the estimate I need it for. If a is a density point of the set {x | fderiv Real f x = 0}, then fderiv Real f x = O(x^r) as x → a implies not only f x - f a = O(x ^ (r + 1)), but f x - f a = o(x ^ (r + 1)). This lemma would allow us to turn this o into a precise estimate based on the part of ball a (dist x a) occupied by zeros of the derivative and the constant in fderiv Real f x = O(x^r). As I said above, this turned out to be not required for the main result.

I formalized this version, because Moreira explicitly claims that the estimate is uniform, and it seemed to be important later, before I slightly changed the argument. I'm OK with leaving this version as a leftover in SardMoreira.

@PatrickMassot
Copy link
Copy Markdown
Member

I’m sorry I forgot about that. I guess we can keep it anyway.
bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 9, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 9, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: a lower bound for the volume of a cone on the unit sphere [Merged by Bors] - feat: a lower bound for the volume of a cone on the unit sphere Jan 9, 2026
@mathlib-bors mathlib-bors bot closed this Jan 9, 2026
@urkud urkud deleted the tosphere-bound branch January 14, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants