Skip to content

[Merged by Bors] - feat(MetricSpace): images and preimages of balls in subtypes#31957

Closed
urkud wants to merge 1 commit intoleanprover-community:masterfrom
urkud:ball-subtype
Closed

[Merged by Bors] - feat(MetricSpace): images and preimages of balls in subtypes#31957
urkud wants to merge 1 commit intoleanprover-community:masterfrom
urkud:ball-subtype

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Nov 22, 2025


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 567fa05a2e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ dist_eq
+ image_ball
+ image_closedBall
+ image_emetricBall
+ image_emetricClosedBall
+ nndist_eq
+ preimage_ball
+ preimage_closedBall
+ preimage_emetricBall
+ preimage_emetricClosedBall
+ pseudoMetricSpace
- Subtype.dist_eq
- Subtype.nndist_eq
- Subtype.pseudoMetricSpace

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Nov 22, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 24, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 24, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(MetricSpace): images and preimages of balls in subtypes [Merged by Bors] - feat(MetricSpace): images and preimages of balls in subtypes Nov 24, 2025
@mathlib-bors mathlib-bors bot closed this Nov 24, 2025
@urkud urkud deleted the ball-subtype branch December 12, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants