[Merged by Bors] - feat: replace Finsupp.embDomain_apply with more general lemma#31929
Closed
kim-em wants to merge 4 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: replace Finsupp.embDomain_apply with more general lemma#31929kim-em wants to merge 4 commits intoleanprover-community:masterfrom
Finsupp.embDomain_apply with more general lemma#31929kim-em wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
1 task
PR summary 963c484655Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Member
|
Is there a general rule here that |
kim-em
added a commit
to kim-em/mathlib4
that referenced
this pull request
Nov 22, 2025
jcommelin
reviewed
Nov 24, 2025
Comment on lines
432
to
437
| classical | ||
| simp_rw [embDomain, coe_mk, mem_map'] | ||
| split_ifs with h | ||
| · refine congr_arg (v : α → M) (f.inj' ?_) | ||
| exact Finset.choose_property (fun a₁ => f a₁ = f a) _ _ | ||
| · exact (notMem_support_iff.1 h).symm |
Member
There was a problem hiding this comment.
Suggested change
| simp [embDomain_apply] |
Contributor
|
✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
|
This pull request has conflicts, please merge |
Contributor
Author
|
bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Finsupp.embDomain_apply with more general lemmaFinsupp.embDomain_apply with more general lemma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
choose_spec#31927