Skip to content

[Merged by Bors] - feat: grind annotation for Embedding.injective#31928

Closed
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em:grind_annotations_embedding_injective
Closed

[Merged by Bors] - feat: grind annotation for Embedding.injective#31928
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em:grind_annotations_embedding_injective

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Nov 22, 2025

No description provided.

@github-actions github-actions bot added the t-logic Logic (model theory, etc) label Nov 22, 2025
@github-actions
Copy link
Copy Markdown

PR summary 82d756ea35

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

theorem mk_coe {α β : Type*} (f : α ↪ β) (inj) : (⟨f, inj⟩ : α ↪ β) = f :=
rfl

@[grind! .] -- This adds `Injective f` into the grind context for every embedding `f : α ↪ β`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When used as a focusing dot, mathlib prefers · over .; do we want the same for grind annotations?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to the focusing dot.

Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2025

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 23, 2025
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Nov 23, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 23, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: grind annotation for Embedding.injective [Merged by Bors] - feat: grind annotation for Embedding.injective Nov 23, 2025
@mathlib-bors mathlib-bors bot closed this Nov 23, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants