[Merged by Bors] - chore(Analysis/Distribution/ContDiffMapSupportedIn): remove _apply le…#31094
Closed
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(Analysis/Distribution/ContDiffMapSupportedIn): remove _apply le…#31094grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
…mmas about instances PR leanprover-community#30198 added both a coe_foo and a foo_apply lemma for foo in {zero,add,sub,neg,smul}: remove the apply lemmas again. - there was no good reason for having both; when in doubt, use coe lemmas - for simp, the coe lemmas are equally strong (and having both is very unusual at best), - when rewriting, one can add Pi.zero_apply and friends.
PR summary e36df9a025Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
1 task
Member
|
Seems fine even without deprecations. bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
#31094) …mmas about instances #30198 added both a coe_foo and a foo_apply lemma for foo in {zero,add,sub,neg,smul}: remove the apply lemmas again. - there was no good reason for having both; when in doubt, use coe lemmas - for simp, the coe lemmas are equally strong (and having both is very unusual at best), - when rewriting, one can add Pi.zero_apply and friends.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Nov 7, 2025
leanprover-community#31094) …mmas about instances leanprover-community#30198 added both a coe_foo and a foo_apply lemma for foo in {zero,add,sub,neg,smul}: remove the apply lemmas again. - there was no good reason for having both; when in doubt, use coe lemmas - for simp, the coe lemmas are equally strong (and having both is very unusual at best), - when rewriting, one can add Pi.zero_apply and friends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mmas about instances
#30198 added both a coe_foo and a foo_apply lemma for foo in {zero,add,sub,neg,smul}: remove the apply lemmas again.
Is it acceptable to omit deprecations? The new lemmas were only around for two weeks, and presumably they are not used by name at all.