[Merged by Bors] - feat: add module instance to ContDiffMapSupportedIn#30198
Closed
luigi-massacci wants to merge 34 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: add module instance to ContDiffMapSupportedIn#30198luigi-massacci wants to merge 34 commits intoleanprover-community:masterfrom
luigi-massacci wants to merge 34 commits intoleanprover-community:masterfrom
Conversation
PR summary 45dfe1bcb6
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Analysis.Distribution.ContDiffMapSupportedIn | 1761 | 1779 | +18 (+1.02%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Analysis.Distribution.ContDiffMapSupportedIn |
18 |
Declarations diff
+ EqOn.comp_left₂
+ add_apply
+ coeHom
+ coeHom_injective
+ coe_add
+ coe_coeHom
+ coe_neg
+ coe_smul
+ coe_sub
+ coe_zero
+ instSMul
+ instSub
+ instance : Add 𝓓^{n}_{K}(E, F)
+ instance : AddCommGroup 𝓓^{n}_{K}(E, F)
+ instance : Neg 𝓓^{n}_{K}(E, F)
+ instance : Zero 𝓓^{n}_{K}(E, F)
+ instance {R} [Semiring R] [Module R F] [SMulCommClass ℝ R F] [ContinuousConstSMul R F] :
+ neg_apply
+ smul_apply
+ sub_apply
+ toBoundedContinuousFunction_apply
+ zero_apply
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Closed
2 tasks
5 tasks
ADedecker
reviewed
Oct 5, 2025
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
Add a module instance for the type `ContDiffMapSupportedIn` of n-times continuously differentiable maps supported in a fixed compact. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de> Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Contributor
|
Build failed (retrying...): |
Contributor
|
There's a long line in this PR: https://github.com/leanprover-community/mathlib4/actions/runs/18594174689/job/53016043606#step:20:5319 bors r- |
Contributor
|
✌️ luigi-massacci can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
|
Canceled. |
grunweg
reviewed
Oct 17, 2025
Contributor
|
Sorry for the failed batch; let's try again. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
Add a module instance for the type `ContDiffMapSupportedIn` of n-times continuously differentiable maps supported in a fixed compact. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de> Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Jlh18
pushed a commit
to Jlh18/mathlib4
that referenced
this pull request
Oct 24, 2025
…nity#30198) Add a module instance for the type `ContDiffMapSupportedIn` of n-times continuously differentiable maps supported in a fixed compact. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de> Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
grunweg
added a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 30, 2025
…mmas about instances PR leanprover-community#30198 added both a coe_foo and a foo_apply lemma for foo in {zero,add,sub,neg,smul}: remove the apply lemmas again. - there was no good reason for having both; when in doubt, use coe lemmas - for simp, the coe lemmas are equally strong (and having both is very unusual at best), - when rewriting, one can add Pi.zero_apply and friends.
grunweg
added a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 30, 2025
…mmas about instances PR leanprover-community#30198 added both a coe_foo and a foo_apply lemma for foo in {zero,add,sub,neg,smul}: remove the apply lemmas again. - there was no good reason for having both; when in doubt, use coe lemmas - for simp, the coe lemmas are equally strong (and having both is very unusual at best), - when rewriting, one can add Pi.zero_apply and friends.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
#31094) …mmas about instances #30198 added both a coe_foo and a foo_apply lemma for foo in {zero,add,sub,neg,smul}: remove the apply lemmas again. - there was no good reason for having both; when in doubt, use coe lemmas - for simp, the coe lemmas are equally strong (and having both is very unusual at best), - when rewriting, one can add Pi.zero_apply and friends.
1 task
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Nov 7, 2025
…nity#30198) Add a module instance for the type `ContDiffMapSupportedIn` of n-times continuously differentiable maps supported in a fixed compact. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de> Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Nov 7, 2025
leanprover-community#31094) …mmas about instances leanprover-community#30198 added both a coe_foo and a foo_apply lemma for foo in {zero,add,sub,neg,smul}: remove the apply lemmas again. - there was no good reason for having both; when in doubt, use coe lemmas - for simp, the coe lemmas are equally strong (and having both is very unusual at best), - when rewriting, one can add Pi.zero_apply and friends.
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a module instance for the type
ContDiffMapSupportedInof n-times continuously differentiable maps supported in a fixed compact.