Skip to content

[Merged by Bors] - chore(Bicategory/Strict): move around files related to strict bicategories#30134

Closed
callesonne wants to merge 4 commits intoleanprover-community:masterfrom
callesonne:moveStrict
Closed

[Merged by Bors] - chore(Bicategory/Strict): move around files related to strict bicategories#30134
callesonne wants to merge 4 commits intoleanprover-community:masterfrom
callesonne:moveStrict

Conversation

@callesonne
Copy link
Copy Markdown
Collaborator

This PR moves around some files in preparation for #30132, which introduces the notion of "strict" pseudofunctors.

I want to add this new definition to the file Bicategory/Functor/Strict.lean, which already contains API for pseudofunctors between strict bicategories. My addition is about strict pseudofunctors between arbitrary bicategories.

To make the distinction more clear I have decided to rearrange the file structure slightly. First I created a folder Bicategory/Strict/ to which I move the file Bicategory/Strict.lean (as Bicategory/Strict/Basic.lean). Then I move the current file Bicategory/Functor/Strict.lean to Bicategory/Strict/Pseudofunctor.lean as I believe this fits better with the contents of the file. Then the name Bicategory/Functor/Strict.lean is freed up to contain the notion of a "strict" pseudofunctor in the upcoming #30132.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2025

PR summary 3a826f51e1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Bicategory.Functor.Strict -391
Mathlib.CategoryTheory.Bicategory.Strict -337
Mathlib.CategoryTheory.Bicategory.Strict.Basic 337
Mathlib.CategoryTheory.Bicategory.Strict.Pseudofunctor 391

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

note: file Mathlib/CategoryTheory/Bicategory/Functor/Strict.lean` was renamed to `Mathlib/CategoryTheory/Bicategory/Strict/Pseudofunctor.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/CategoryTheory/Bicategory/Strict.lean` was renamed to `Mathlib/CategoryTheory/Bicategory/Strict/Basic.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@github-actions github-actions bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Oct 2, 2025
@joelriou
Copy link
Copy Markdown
Contributor

joelriou commented Oct 2, 2025

Thanks!
bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 2, 2025
…ories (#30134)

This PR moves around some files in preparation for #30132, which introduces the notion of "strict" pseudofunctors.

I want to add this new definition to the file `Bicategory/Functor/Strict.lean`, which already contains API for pseudofunctors *between* strict bicategories. My addition is about strict pseudofunctors between arbitrary bicategories.

To make the distinction more clear I have decided to rearrange the file structure slightly. First I created a folder `Bicategory/Strict/` to which I move the file `Bicategory/Strict.lean` (as `Bicategory/Strict/Basic.lean`). Then I move the current file `Bicategory/Functor/Strict.lean` to `Bicategory/Strict/Pseudofunctor.lean` as I believe this fits better with the contents of the file. Then the name `Bicategory/Functor/Strict.lean` is freed up to contain the notion of a "strict" pseudofunctor in the upcoming #30132.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 2, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Bicategory/Strict): move around files related to strict bicategories [Merged by Bors] - chore(Bicategory/Strict): move around files related to strict bicategories Oct 2, 2025
@mathlib-bors mathlib-bors bot closed this Oct 2, 2025
mitchell-horner pushed a commit to mitchell-horner/mathlib4 that referenced this pull request Oct 6, 2025
…ories (leanprover-community#30134)

This PR moves around some files in preparation for leanprover-community#30132, which introduces the notion of "strict" pseudofunctors.

I want to add this new definition to the file `Bicategory/Functor/Strict.lean`, which already contains API for pseudofunctors *between* strict bicategories. My addition is about strict pseudofunctors between arbitrary bicategories.

To make the distinction more clear I have decided to rearrange the file structure slightly. First I created a folder `Bicategory/Strict/` to which I move the file `Bicategory/Strict.lean` (as `Bicategory/Strict/Basic.lean`). Then I move the current file `Bicategory/Functor/Strict.lean` to `Bicategory/Strict/Pseudofunctor.lean` as I believe this fits better with the contents of the file. Then the name `Bicategory/Functor/Strict.lean` is freed up to contain the notion of a "strict" pseudofunctor in the upcoming leanprover-community#30132.
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
…ories (leanprover-community#30134)

This PR moves around some files in preparation for leanprover-community#30132, which introduces the notion of "strict" pseudofunctors.

I want to add this new definition to the file `Bicategory/Functor/Strict.lean`, which already contains API for pseudofunctors *between* strict bicategories. My addition is about strict pseudofunctors between arbitrary bicategories.

To make the distinction more clear I have decided to rearrange the file structure slightly. First I created a folder `Bicategory/Strict/` to which I move the file `Bicategory/Strict.lean` (as `Bicategory/Strict/Basic.lean`). Then I move the current file `Bicategory/Functor/Strict.lean` to `Bicategory/Strict/Pseudofunctor.lean` as I believe this fits better with the contents of the file. Then the name `Bicategory/Functor/Strict.lean` is freed up to contain the notion of a "strict" pseudofunctor in the upcoming leanprover-community#30132.
@callesonne callesonne deleted the moveStrict branch December 4, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file-removed A Lean module was (re)moved without a `deprecated_module` annotation ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants