Skip to content

[Merged by Bors] - feat(Bicategory/Functor/Strict): add StrictPseudofunctor#30132

Closed
callesonne wants to merge 24 commits intoleanprover-community:masterfrom
callesonne:isStrict
Closed

[Merged by Bors] - feat(Bicategory/Functor/Strict): add StrictPseudofunctor#30132
callesonne wants to merge 24 commits intoleanprover-community:masterfrom
callesonne:isStrict

Conversation

@callesonne
Copy link
Copy Markdown
Collaborator

@callesonne callesonne commented Oct 2, 2025

This PR adds the notion of a strict pseudofunctor, where the coherence isomorphisms are equalities. This will be useful for #25561 where I define the bicategory of groupoids.


Open in Gitpod

@callesonne callesonne added the t-category-theory Category theory label Oct 2, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2025

PR summary b7543c7cba

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ StrictPseudofunctor
+ StrictPseudofunctorCore
+ StrictPseudofunctorPreCore
+ comp
+ id
+ mk'
+ mk''
+ toFunctor

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Oct 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 2, 2025
…ories (#30134)

This PR moves around some files in preparation for #30132, which introduces the notion of "strict" pseudofunctors.

I want to add this new definition to the file `Bicategory/Functor/Strict.lean`, which already contains API for pseudofunctors *between* strict bicategories. My addition is about strict pseudofunctors between arbitrary bicategories.

To make the distinction more clear I have decided to rearrange the file structure slightly. First I created a folder `Bicategory/Strict/` to which I move the file `Bicategory/Strict.lean` (as `Bicategory/Strict/Basic.lean`). Then I move the current file `Bicategory/Functor/Strict.lean` to `Bicategory/Strict/Pseudofunctor.lean` as I believe this fits better with the contents of the file. Then the name `Bicategory/Functor/Strict.lean` is freed up to contain the notion of a "strict" pseudofunctor in the upcoming #30132.
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Oct 2, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@github-actions github-actions bot removed the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Oct 2, 2025
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 3, 2025
@joelriou joelriou requested a review from robin-carlier October 3, 2025 19:10
mitchell-horner pushed a commit to mitchell-horner/mathlib4 that referenced this pull request Oct 6, 2025
…ories (leanprover-community#30134)

This PR moves around some files in preparation for leanprover-community#30132, which introduces the notion of "strict" pseudofunctors.

I want to add this new definition to the file `Bicategory/Functor/Strict.lean`, which already contains API for pseudofunctors *between* strict bicategories. My addition is about strict pseudofunctors between arbitrary bicategories.

To make the distinction more clear I have decided to rearrange the file structure slightly. First I created a folder `Bicategory/Strict/` to which I move the file `Bicategory/Strict.lean` (as `Bicategory/Strict/Basic.lean`). Then I move the current file `Bicategory/Functor/Strict.lean` to `Bicategory/Strict/Pseudofunctor.lean` as I believe this fits better with the contents of the file. Then the name `Bicategory/Functor/Strict.lean` is freed up to contain the notion of a "strict" pseudofunctor in the upcoming leanprover-community#30132.
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 13, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 25, 2025
@callesonne
Copy link
Copy Markdown
Collaborator Author

I noticed that @robin-carlier has added StrictlyUnitary.lean so I ditched the approach with IsStrict and instead copied the approach taken in that file.

@callesonne callesonne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 25, 2025
@callesonne callesonne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 11, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
@dagurtomas
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 19, 2025
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 19, 2025
…lean

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@callesonne callesonne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 19, 2025
@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Nov 23, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2025
This PR adds the notion of a strict pseudofunctor, where the coherence isomorphisms are equalities. This will be useful for #25561 where I define the bicategory of groupoids.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Bicategory/Functor/Strict): add StrictPseudofunctor [Merged by Bors] - feat(Bicategory/Functor/Strict): add StrictPseudofunctor Nov 23, 2025
@mathlib-bors mathlib-bors bot closed this Nov 23, 2025
@callesonne callesonne deleted the isStrict branch December 4, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants