[Merged by Bors] - refactor: weaken HasPullbacks to HasPullback in MorphismProperty.OverAdjuction#29810
Closed
Jlh18 wants to merge 16 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - refactor: weaken HasPullbacks to HasPullback in MorphismProperty.OverAdjuction#29810Jlh18 wants to merge 16 commits intoleanprover-community:masterfrom
Jlh18 wants to merge 16 commits intoleanprover-community:masterfrom
Conversation
PR summary 1d032835a0Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
3 tasks
Collaborator
|
This pull request has conflicts, please merge |
Collaborator
|
This PR/issue depends on: |
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
…Adjuction (#29810) This PR replaces the global assumption of `HasPullback T` with the weaker assumption that pullbacks exist along the morphism only. For the sake of readability I also moved the variable `(f : X -> Y)` into the statement of each theorem. As instructed in #29795 (comment) - [ ] depends on: #29795 - [ ] depends on: #29812 Co-authored-by: jlh18 <josephhua73@yahoo.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Jlh18
added a commit
to Jlh18/mathlib4
that referenced
this pull request
Oct 24, 2025
…Adjuction (leanprover-community#29810) This PR replaces the global assumption of `HasPullback T` with the weaker assumption that pullbacks exist along the morphism only. For the sake of readability I also moved the variable `(f : X -> Y)` into the statement of each theorem. As instructed in leanprover-community#29795 (comment) - [ ] depends on: leanprover-community#29795 - [ ] depends on: leanprover-community#29812 Co-authored-by: jlh18 <josephhua73@yahoo.com>
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Nov 7, 2025
…Adjuction (leanprover-community#29810) This PR replaces the global assumption of `HasPullback T` with the weaker assumption that pullbacks exist along the morphism only. For the sake of readability I also moved the variable `(f : X -> Y)` into the statement of each theorem. As instructed in leanprover-community#29795 (comment) - [ ] depends on: leanprover-community#29795 - [ ] depends on: leanprover-community#29812 Co-authored-by: jlh18 <josephhua73@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the global assumption of
HasPullback Twith the weaker assumption that pullbacks exist along the morphism only.For the sake of readability I also moved the variable
(f : X -> Y)into the statement of each theorem. As instructed in #29795 (comment)