Skip to content

[Merged by Bors] - feat: finsum and locally finite sums of differentiable sections are differentiable#29686

Closed
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:mdifferentiable-ops-mirror
Closed

[Merged by Bors] - feat: finsum and locally finite sums of differentiable sections are differentiable#29686
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:mdifferentiable-ops-mirror

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Sep 15, 2025 •
edited
Loading

Mirrors analogous API for C^n sections; this is added mostly for completeness.
Follow-up to #26871.

Hence, this also originated from our work towards the path towards geodesics and the Levi-Civita connection.

Open in Gitpod

@grunweg grunweg added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-differential-geometry Manifolds etc labels Sep 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 15, 2025 •
edited
Loading

PR summary 12130d8fdf

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ MDifferentiable.finsum_section_of_locallyFinite
+ MDifferentiable.sum_section_of_locallyFinite
+ MDifferentiableAt.finsum_section_of_locallyFinite
+ MDifferentiableAt.sum_section_of_locallyFinite
+ MDifferentiableOn.finsum_section_of_locallyFinite
+ MDifferentiableOn.smul_section_of_tsupport
+ MDifferentiableOn.sum_section_of_locallyFinite
+ MDifferentiableWithinAt.congr'
+ MDifferentiableWithinAt.finsum_section_of_locallyFinite
+ MDifferentiableWithinAt.sum_section_of_locallyFinite

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg force-pushed the mdifferentiable-ops-mirror branch from 14c95cc to 5bad73f Compare September 27, 2025 11:24
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 27, 2025

@ocfnash Would you like to review this PR also? Thanks!

sgouezel
sgouezel reviewed Sep 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 27, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 27, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 27, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Sep 27, 2025

This PR/issue depends on:

grunweg and others added 3 commits September 27, 2025 13:57
@grunweg @sgouezel
Apply suggestions from code review
813e9f9 
Co-authored-by: Sebastien Gouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
More review comments
4d16877
@grunweg
Golf
794a5ac
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 27, 2025

Thank you for the quick review!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Sep 27, 2025
@grunweg
feat: finsum and locally finite sums of differentiable sections are…
79c7feb 
… differentiable (#29686)

Mirrors analogous API for C^n sections; this is added mostly for completeness.
Follow-up to #26871.

Hence, this also originated from our work towards the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 27, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: finsum and locally finite sums of differentiable sections are differentiable [Merged by Bors] - feat: finsum and locally finite sums of differentiable sections are differentiable Sep 27, 2025
@mathlib-bors mathlib-bors bot closed this Sep 27, 2025
@grunweg grunweg deleted the mdifferentiable-ops-mirror branch September 27, 2025 13:42
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
@grunweg @joelriou
feat: finsum and locally finite sums of differentiable sections are…
e7c366c 
… differentiable (leanprover-community#29686)

Mirrors analogous API for C^n sections; this is added mostly for completeness.
Follow-up to leanprover-community#26871.

Hence, this also originated from our work towards the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
@grunweg @BeibeiX0
feat: finsum and locally finite sums of differentiable sections are…
8c504a0 
… differentiable (leanprover-community#29686)

Mirrors analogous API for C^n sections; this is added mostly for completeness.
Follow-up to leanprover-community#26871.

Hence, this also originated from our work towards the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grunweg @mathlib4-dependent-issues-bot @sgouezel