Skip to content

[Merged by Bors] - feat: finite sum, difference, scalar product of differentiable sections is differentiable#26871

Closed
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:MR-mdifferentiable-ops
Closed

[Merged by Bors] - feat: finite sum, difference, scalar product of differentiable sections is differentiable#26871
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:MR-mdifferentiable-ops

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 7, 2025

This mirrors the additions of #26674 to mdifferentiable sections.
Part of the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot patrickmassot@free.fr


Open in Gitpod

@github-actions github-actions bot added the t-differential-geometry Manifolds etc label Jul 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 7, 2025

PR summary af353e32f4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ MDifferentiable.sum_section
+ MDifferentiableAt.smul_const_section
+ MDifferentiableAt.smul_section
+ MDifferentiableAt.sum_section
+ MDifferentiableOn.smul_const_section
+ MDifferentiableOn.smul_section
+ MDifferentiableOn.sum_section
+ MDifferentiableWithinAt.smul_section
+ MDifferentiableWithinAt.sum_section
+ mDifferentiableOn_sub_section
+ mdifferentiableAt_add_section
+ mdifferentiableAt_neg_section
+ mdifferentiableAt_sub_section
+ mdifferentiableOn_add_section
+ mdifferentiableOn_neg_section
+ mdifferentiableWithinAt_add_section
+ mdifferentiableWithinAt_neg_section
+ mdifferentiableWithinAt_smul_const_section
+ mdifferentiableWithinAt_sub_section
+ mdifferentiable_add_section
+ mdifferentiable_neg_section
+ mdifferentiable_smul_const_section
+ mdifferentiable_smul_section
+ mdifferentiable_sub_section

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg mentioned this pull request Jul 7, 2025
35 tasks
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 7, 2025
@grunweg grunweg changed the title Everything, with all the deps. TODO, make the same fixes! feat: finite sum, difference, scalar product of differentiable sections is differentiable Jul 7, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 7, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 15, 2025
@grunweg grunweg force-pushed the MR-mdifferentiable-ops branch from f33ba4b to e2e7185 Compare September 15, 2025 20:04
@grunweg grunweg removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 15, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one minor suggestion.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 24, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 24, 2025
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 27, 2025

Thank you for the review!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Sep 27, 2025
…ns is differentiable (#26871)

This mirrors the additions of #26674 to `mdifferentiable` sections.
Part of the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 27, 2025

Canceled.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 27, 2025

I'm not sure why CI failed (edit: ah, that was a known issue not caused by this PR): let's try merging master and see what happens.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 27, 2025

CI is green: let's try again!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Sep 27, 2025
…ns is differentiable (#26871)

This mirrors the additions of #26674 to `mdifferentiable` sections.
Part of the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 27, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: finite sum, difference, scalar product of differentiable sections is differentiable [Merged by Bors] - feat: finite sum, difference, scalar product of differentiable sections is differentiable Sep 27, 2025
@mathlib-bors mathlib-bors bot closed this Sep 27, 2025
@grunweg grunweg deleted the MR-mdifferentiable-ops branch September 27, 2025 11:23
mathlib-bors bot pushed a commit that referenced this pull request Sep 27, 2025
… differentiable (#29686)

Mirrors analogous API for C^n sections; this is added mostly for completeness.
Follow-up to #26871.

Hence, this also originated from our work towards the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
…ns is differentiable (leanprover-community#26871)

This mirrors the additions of leanprover-community#26674 to `mdifferentiable` sections.
Part of the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
… differentiable (leanprover-community#29686)

Mirrors analogous API for C^n sections; this is added mostly for completeness.
Follow-up to leanprover-community#26871.

Hence, this also originated from our work towards the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
…ns is differentiable (leanprover-community#26871)

This mirrors the additions of leanprover-community#26674 to `mdifferentiable` sections.
Part of the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
… differentiable (leanprover-community#29686)

Mirrors analogous API for C^n sections; this is added mostly for completeness.
Follow-up to leanprover-community#26871.

Hence, this also originated from our work towards the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants