[Merged by Bors] - chore(MathlibTest/FieldSimp): more tests#28646
Closed
hrmacbeth wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(MathlibTest/FieldSimp): more tests#28646hrmacbeth wants to merge 1 commit intoleanprover-community:masterfrom
hrmacbeth wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 3e97beff8aImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
hrmacbeth
commented
Aug 19, 2025
Comment on lines
-519
to
-530
| guard_target = | ||
| ((F x * F x * 2 - (F x * F x + F y * F y - F (x - y) * F (x - y))) | ||
| * (F y * F y * 2 - (F x * F x + F y * F y - F (x - y) * F (x - y))) | ||
| * F x * F y * F (x - y) * F (x - y) * (2 * 2) | ||
| - 2 * (F x * F (x - y)) * (2 * (F y * F (x - y))) * | ||
| (F x * F x * (F y * F y) * (2 * 2) | ||
| - (F x * F x + F y * F y - F (x - y) * F (x - y)) | ||
| * (F x * F x + F y * F y - F (x - y) * F (x - y)))) | ||
| * (2 * (F x * F y)) | ||
| = (F (x - y) * F (x - y) - (F x * F x + F y * F y)) | ||
| * F x * F y * F (x - y) * F (x - y) | ||
| * (2 * (F x * F (x - y)) * (2 * (F y * F (x - y))) * (2 * 2)) |
Member
Author
There was a problem hiding this comment.
Deleting this check because it is time-consuming enough to seriously affect the heartbeat count! (In the new implementation it accounts for 2/3 of the heartbeats.)
hrmacbeth
commented
Aug 19, 2025
| #guard_msgs in | ||
| example {a : Nat} : P (a* x - a * x) := by test_field_simp | ||
|
|
||
| -- We simplify multiplication by one, but not by e.g. two, and do not simplify literals. |
Member
Author
There was a problem hiding this comment.
This section is not deleted, just moved down later in the file.
grunweg
reviewed
Aug 19, 2025
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
|
Thanks! |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Aug 20, 2025
Following on from leanprover-community#28362 and leanprover-community#28413: a few more `field_simp` tests and light cleanup of the test file.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
Following on from leanprover-community#28362 and leanprover-community#28413: a few more `field_simp` tests and light cleanup of the test file.
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
Following on from leanprover-community#28362 and leanprover-community#28413: a few more `field_simp` tests and light cleanup of the test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #28362 and #28413: a few more
field_simptests and light cleanup of the test file.