[Merged by Bors] - feat(MathlibTest/FieldSimp): comprehensive test file#28362
Closed
hrmacbeth wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(MathlibTest/FieldSimp): comprehensive test file#28362hrmacbeth wants to merge 2 commits intoleanprover-community:masterfrom
hrmacbeth wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary ed52228da9Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
eric-wieser
reviewed
Aug 14, 2025
eric-wieser
reviewed
Aug 14, 2025
|
|
||
| /-! ### Most common use case: Cancel denominators to something solvable by `ring` | ||
|
|
||
| When (eventually) this is robust enough, there should be a `field` tactic |
Member
There was a problem hiding this comment.
Could you add an explanation here that TODO (new implementation) refers to this not-yet-extant field tactic?
Member
Author
There was a problem hiding this comment.
TODO (new implementation) just signifies tasks that should be in scope for field_simp, but that would require switching field_simp to a different implementation (e.g. our WIP re-implementation).
It's not referring to the idea I mention here, that there should be a field tactic.
eric-wieser
reviewed
Aug 14, 2025
Contributor
|
✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
`field_simp`'s current test file is very short: it contains regression tests for bugs noticed over the years and documents a few features added after the original implementation. In preparation for a planned refactor of `field_simp` by @FLDutchmann @grunweg and me, this PR provides a comprehensive test file for `field_simp`. Co-authored-by: Michael Rothgang @grunweg
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Add a few more tests documenting current features of field_simp (or their absence). Extension to #28362; all of these have been discussed in the current field_simp rewrite with @FLDutchmann and @hrmacbeth.
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Aug 20, 2025
Following on from leanprover-community#28362 and leanprover-community#28413: a few more `field_simp` tests and light cleanup of the test file.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…unity#28362) `field_simp`'s current test file is very short: it contains regression tests for bugs noticed over the years and documents a few features added after the original implementation. In preparation for a planned refactor of `field_simp` by @FLDutchmann @grunweg and me, this PR provides a comprehensive test file for `field_simp`. Co-authored-by: Michael Rothgang @grunweg
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…ty#28413) Add a few more tests documenting current features of field_simp (or their absence). Extension to leanprover-community#28362; all of these have been discussed in the current field_simp rewrite with @FLDutchmann and @hrmacbeth.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
Following on from leanprover-community#28362 and leanprover-community#28413: a few more `field_simp` tests and light cleanup of the test file.
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
…unity#28362) `field_simp`'s current test file is very short: it contains regression tests for bugs noticed over the years and documents a few features added after the original implementation. In preparation for a planned refactor of `field_simp` by @FLDutchmann @grunweg and me, this PR provides a comprehensive test file for `field_simp`. Co-authored-by: Michael Rothgang @grunweg
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
…ty#28413) Add a few more tests documenting current features of field_simp (or their absence). Extension to leanprover-community#28362; all of these have been discussed in the current field_simp rewrite with @FLDutchmann and @hrmacbeth.
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
Following on from leanprover-community#28362 and leanprover-community#28413: a few more `field_simp` tests and light cleanup of the test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
field_simp's current test file is very short: it contains regression tests for bugs noticed over the years and documents a few features added after the original implementation.In preparation for a planned refactor of
field_simpby @FLDutchmann @grunweg and me, this PR provides a comprehensive test file forfield_simp.Co-authored-by: Michael Rothgang @grunweg