Skip to content

[Merged by Bors] - refactor: tidy mulVec and vecMul lemmas about •#28450

Closed
eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser/vecMul_smul
Closed

[Merged by Bors] - refactor: tidy mulVec and vecMul lemmas about •#28450
eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser/vecMul_smul

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Aug 14, 2025 •
edited
Loading

This deprecates two _assoc lemmas, and moves a third without deprecation to resolve a name clash.
Only mulVec_smul was previously correctly-named (but duplicated).

vecMul_smul was missing altogether.

Moves:

  • Matrix.smul_mulVec_assoc -> Matrix.smul_mulVec
  • Matrix.mulVec_smul_assoc -> Matrix.mulVec_smul
  • Matrix.vecMul_smul -> Matrix.smul_vecMul

Open in Gitpod

@eric-wieser eric-wieser added the t-algebra Algebra (groups, rings, fields, etc) label Aug 14, 2025
@eric-wieser eric-wieser mentioned this pull request Aug 14, 2025
Closed
1 task
@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Aug 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 14, 2025 •
edited
Loading

PR summary 218e764a49

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ smul_mulVec
+ smul_vecMul

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser eric-wieser force-pushed the eric-wieser/vecMul_smul branch from 390ac8c to 44ba564 Compare August 14, 2025 22:55
@eric-wieser eric-wieser mentioned this pull request Aug 14, 2025
Closed
1 task
@eric-wieser eric-wieser force-pushed the eric-wieser/vecMul_smul branch from 44ba564 to 12f5cfe Compare August 14, 2025 22:59
@eric-wieser eric-wieser changed the title feat: missing mulVec and vecMul lemmas about • refactor: rename mulVec and vecMul lemmas about • Aug 14, 2025
@eric-wieser eric-wieser changed the title refactor: rename mulVec and vecMul lemmas about • refactor: tidy mulVec and vecMul lemmas about • Aug 14, 2025
@eric-wieser eric-wieser requested a review from ocfnash August 15, 2025 00:05
loefflerd
loefflerd reviewed Aug 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor style nit

@loefflerd loefflerd mentioned this pull request Aug 15, 2025
Closed
5 tasks
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Aug 15, 2025

Thank you both!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 15, 2025

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 15, 2025
@eric-wieser
Copy link
Copy Markdown
Member Author

eric-wieser commented Aug 15, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 15, 2025
@eric-wieser
refactor: tidy mulVec and vecMul lemmas about • (#28450)
595c2c6 
This deprecates two `_assoc` lemmas, and moves a third without deprecation to resolve a name clash.
Only `mulVec_smul` was previously correctly-named (but duplicated).

`vecMul_smul` was missing altogether.

Moves:
- `Matrix.smul_mulVec_assoc` -> `Matrix.smul_mulVec`
- `Matrix.mulVec_smul_assoc` -> `Matrix.mulVec_smul`
- `Matrix.vecMul_smul` -> `Matrix.smul_vecMul`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: tidy mulVec and vecMul lemmas about • [Merged by Bors] - refactor: tidy mulVec and vecMul lemmas about • Aug 15, 2025
@mathlib-bors mathlib-bors bot closed this Aug 15, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser/vecMul_smul branch August 15, 2025 22:52
Julian added a commit to Aaron1011/mathlib4 that referenced this pull request Aug 16, 2025
@Julian
Merge remote-tracking branch 'origin/master' into gromov-growth
74c41e2 
* origin/master: (508 commits)
  feat(Logic/Basic): forall_and_index (leanprover-community#27737)
  feat(Algebra/intNorm): `x` divides `intNorm x` (leanprover-community#28021)
  feat(RingTheory/MvPolynomial/MonomialOrder): some lemmas about degree (leanprover-community#26000)
  chore: more elementary Motzkin polynomial proof (leanprover-community#28482)
  feat: e-seminormed monoid (leanprover-community#27385)
  feat(RingTheory): ` (⊥ : Ideal R) ^ n = ⊥` (leanprover-community#28171)
  fix(LinearAlgebra/Dimension/ErdosKaplansky): authorship (leanprover-community#28513)
  chore: golf entire `X_pow_eq_monomial` (leanprover-community#28504)
  feat(RingTheory): invertible modules and Picard group (leanprover-community#25337)
  chore: use delta `deriving` for leanprover-community#380 (leanprover-community#28498)
  feat: add bilinear maps for vector/matrix products (leanprover-community#28130)
  feat(Counterexamples): topologists' sine curve (leanprover-community#25833)
  feat(Analysis/Convex): doubly stochastic matrices have operator norm at most one (leanprover-community#28453)
  chore(Topology/Compactification): deprecate duplicate `ultrafilter_pure_injective` (leanprover-community#28436)
  feat: add `@[simp]` to `Multiset.cons_le_cons` and `Finset.insert_subset_insert` (leanprover-community#28285)
  feat: make `ring` work for semifields (leanprover-community#28494)
  feat: filtering lists and bounded quantifiers are primitive recursive (leanprover-community#26295)
  chore(Analysis/Analytic): split `Analytic.Basic` (leanprover-community#26270)
  refactor: tidy `mulVec` and `vecMul` lemmas about `•` (leanprover-community#28450)
  feat(Order/WellFounded): Acc and infinite descending chain (leanprover-community#28120)
  feat(NumberTheory/Padics): {Int,Rat}.padicValuation (leanprover-community#27667)
  chore(*): address a few timeout-related porting notes (leanprover-community#28483)
  feat(Algebra): toAlgebra_algebraMap (leanprover-community#28238)
  feat(Shrink): `IsCancelMul` instance (leanprover-community#28407)
  chore(Geometry): golf entire `chart_eq'` and `orthogonalProjection_orthogonalProjection` (leanprover-community#28485)
  feat: shifted geometric series and a `ProbabilityMeasure` version of `measure_iUnion_le` (leanprover-community#28087)
  chore(LinearAlgebra/PiTensorProduct): `rw` away use of `erw` in `lifts_zero` (leanprover-community#27554)
  feat(RingTheory): faithfully flat ring maps (leanprover-community#24530)
  chore(Geometry/RingedSpace): remove use of `erw` in `stalkSpecializes_stalkMap` (leanprover-community#27656)
  chore: add the Brownian motion project to downstream_repos.yml (leanprover-community#28459)
  feat(CategoryTheory/Sites/SheafOfTypes): composition of a sheaf with uliftFunctor is still a sheaf (leanprover-community#27816)
  feat(Valuation/DiscreteValuationRel): val relations with compatible valuations to Zm0 are IsDiscrete (leanprover-community#27213)
  chore(*): process a bunch of `aesop`-related porting notes (leanprover-community#28402)
  feat(CategoryTheory): abstract argument for the stability under transfinite compositions (leanprover-community#26030)
  chore: bump toolchain to v4.23.0-rc2 (leanprover-community#28454)
  chore(FieldTheory/Finite): fermat's little theorem in Nat form (leanprover-community#27962)
  feat(Combinatorics/SimpleGraph/Paths): add theorem `SimpleGraph.Walk.IsPath.concat` (leanprover-community#27582)
  feat(Slope): slope_pos_iff_of_le and related lemmas (leanprover-community#28039)
  feat: tactic analysis framework (leanprover-community#26683)
  chore(Data/EReal): deprecate `add_pos_of_nonneg_of_pos` and `add_ne_top_iff_of_ne_bot` (duplicates) (leanprover-community#28424)
  feat(MathlibTest/FieldSimp): add a few more tests (leanprover-community#28413)
  chore(RingTheory/HahnSeries): deprecate duplicate `orderTop_add_orderTop_le_orderTop_mul` (leanprover-community#28231)
  chore(AlgebraicGeometry/IdealSheaf): deprecate duplicate `AlgebraicGeometry.Scheme.IdealSheafData.Scheme.zeroLocus_radical` (leanprover-community#28202)
  feat(Algebra/Order): ArchimedeanClass ball (leanprover-community#27885)
  chore(Geometry/RingedSpace): remove use of `erw` in `isUnit_of_isUnit_germ` (leanprover-community#27660)
  feat(SkewMonoidAlgebra): coeff_mul lemmas (leanprover-community#27255)
  chore(LinearAlgebra): golf entire `isUnit_det` (leanprover-community#28438)
  chore(FieldTheory/IntermediateField): golf entire `coe_sum` and `coe_prod` (leanprover-community#28431)
  feat: separate linter error message for empty doc-strings (leanprover-community#27895)
  feat(RingTheory/PowerSeries/Binomial): add basic lemmas, golf (leanprover-community#27497)
  ...
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@eric-wieser @Paul-Lez
refactor: tidy mulVec and vecMul lemmas about • (leanprover-com…
cc43b6e 
…munity#28450)

This deprecates two `_assoc` lemmas, and moves a third without deprecation to resolve a name clash.
Only `mulVec_smul` was previously correctly-named (but duplicated).

`vecMul_smul` was missing altogether.

Moves:
- `Matrix.smul_mulVec_assoc` -> `Matrix.smul_mulVec`
- `Matrix.mulVec_smul_assoc` -> `Matrix.mulVec_smul`
- `Matrix.vecMul_smul` -> `Matrix.smul_vecMul`
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
@eric-wieser @pechersky
refactor: tidy mulVec and vecMul lemmas about • (leanprover-com…
83cab7b 
…munity#28450)

This deprecates two `_assoc` lemmas, and moves a third without deprecation to resolve a name clash.
Only `mulVec_smul` was previously correctly-named (but duplicated).

`vecMul_smul` was missing altogether.

Moves:
- `Matrix.smul_mulVec_assoc` -> `Matrix.smul_mulVec`
- `Matrix.mulVec_smul_assoc` -> `Matrix.mulVec_smul`
- `Matrix.vecMul_smul` -> `Matrix.smul_vecMul`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loefflerd loefflerd loefflerd left review comments

@ocfnash ocfnash Awaiting requested review from ocfnash

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eric-wieser @ocfnash @loefflerd