Skip to content

[Merged by Bors] - feat(NumberTheory/Padics): {Int,Rat}.padicValuation#27667

Closed
pechersky wants to merge 14 commits intoleanprover-community:masterfrom
pechersky:int-rat-padic-val
Closed

[Merged by Bors] - feat(NumberTheory/Padics): {Int,Rat}.padicValuation#27667
pechersky wants to merge 14 commits intoleanprover-community:masterfrom
pechersky:int-rat-padic-val

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

@pechersky pechersky commented Jul 30, 2025 •
edited by riccardobrasca
Loading

padicVal{Int,Rat} in Valuation form, sending to ℤᵐ⁰

We didn't have a valuation that mentioned Rat and Valuation together before.
On the way to show that ℚ_[p] (resp. ℤ_[p]) is equivalent to Completion (WithVal v) for the v defined here

Open in Gitpod

@pechersky pechersky added t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields, etc) labels Jul 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 30, 2025 •
edited
Loading

PR summary 3fe589e8d2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Int.padicValuation
+ Int.padicValuation_eq_one_iff
+ Int.padicValuation_eq_zero_iff
+ Int.padicValuation_le_one
+ Int.padicValuation_lt_one_iff
+ Int.padicValuation_self
+ Rat.padicValuation
+ Rat.padicValuation_cast
+ Rat.padicValuation_eq_zero_iff
+ Rat.padicValuation_le_one_iff
+ Rat.padicValuation_self
+ comap_mulValuation_eq_int_padicValuation
+ comap_mulValuation_eq_padicValuation
+ eq_zero_iff
+ norm_eq_zpow_log_mulValuation

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 30, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 6, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

mathlib4-merge-conflict-bot commented Aug 6, 2025

This pull request has conflicts, please merge master and resolve them.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 6, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Aug 6, 2025

This PR/issue depends on:

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 6, 2025
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Aug 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 14, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 14, 2025
faenuccio
faenuccio reviewed Aug 15, 2025
View reviewed changes
@faenuccio
Copy link
Copy Markdown
Contributor

faenuccio commented Aug 15, 2025

I've added two minor comments for the code. Overall, I think it would be important to show that Z_p is the valuation subring of Q_p in terms of ValuationSubring. This is done in our repo with @mariainesdff if you need inspiration/suggestion. Of course, it would also be OK to mention it in a TODO in the doc section.

mattrobball
mattrobball reviewed Aug 15, 2025
View reviewed changes
@pechersky @mattrobball
Update Mathlib/NumberTheory/Padics/PadicNumbers.lean
193c5dc 
Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
@mattrobball
Copy link
Copy Markdown
Contributor

mattrobball commented Aug 15, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 15, 2025
@ghost ghost removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 15, 2025
@pechersky
feat(NumberTheory/Padics): {Int,Rat}.padicValuation (#27667)
e218f19 
`padicVal{Int,Rat}` in `Valuation` form, sending to `ℤᵐ⁰`

We didn't have a valuation that mentioned Rat and Valuation together before.
On the way to show that `ℚ_[p]` (resp. `ℤ_[p]`) is equivalent to `Completion (WithVal v)` for the `v` defined here



Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 15, 2025

Build failed:

@mattrobball
Copy link
Copy Markdown
Contributor

mattrobball commented Aug 15, 2025

Hmm. I thought it was something in CI.

bors r-

bors delegate+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 15, 2025

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed ready-to-merge This PR has been sent to bors. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). labels Aug 15, 2025
@pechersky
Copy link
Copy Markdown
Contributor Author

pechersky commented Aug 15, 2025

@YaelDillies @Louddy Are we really saying that now exp (-1) simp nf is (exp 1)⁻¹?

@pechersky
Copy link
Copy Markdown
Contributor Author

pechersky commented Aug 15, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 15, 2025
@pechersky
feat(NumberTheory/Padics): {Int,Rat}.padicValuation (#27667)
671301c 
`padicVal{Int,Rat}` in `Valuation` form, sending to `ℤᵐ⁰`

We didn't have a valuation that mentioned Rat and Valuation together before.
On the way to show that `ℚ_[p]` (resp. `ℤ_[p]`) is equivalent to `Completion (WithVal v)` for the `v` defined here



Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberTheory/Padics): {Int,Rat}.padicValuation [Merged by Bors] - feat(NumberTheory/Padics): {Int,Rat}.padicValuation Aug 15, 2025
@mathlib-bors mathlib-bors bot closed this Aug 15, 2025
Julian added a commit to Aaron1011/mathlib4 that referenced this pull request Aug 16, 2025
@Julian
Merge remote-tracking branch 'origin/master' into gromov-growth
74c41e2 
* origin/master: (508 commits)
  feat(Logic/Basic): forall_and_index (leanprover-community#27737)
  feat(Algebra/intNorm): `x` divides `intNorm x` (leanprover-community#28021)
  feat(RingTheory/MvPolynomial/MonomialOrder): some lemmas about degree (leanprover-community#26000)
  chore: more elementary Motzkin polynomial proof (leanprover-community#28482)
  feat: e-seminormed monoid (leanprover-community#27385)
  feat(RingTheory): ` (⊥ : Ideal R) ^ n = ⊥` (leanprover-community#28171)
  fix(LinearAlgebra/Dimension/ErdosKaplansky): authorship (leanprover-community#28513)
  chore: golf entire `X_pow_eq_monomial` (leanprover-community#28504)
  feat(RingTheory): invertible modules and Picard group (leanprover-community#25337)
  chore: use delta `deriving` for leanprover-community#380 (leanprover-community#28498)
  feat: add bilinear maps for vector/matrix products (leanprover-community#28130)
  feat(Counterexamples): topologists' sine curve (leanprover-community#25833)
  feat(Analysis/Convex): doubly stochastic matrices have operator norm at most one (leanprover-community#28453)
  chore(Topology/Compactification): deprecate duplicate `ultrafilter_pure_injective` (leanprover-community#28436)
  feat: add `@[simp]` to `Multiset.cons_le_cons` and `Finset.insert_subset_insert` (leanprover-community#28285)
  feat: make `ring` work for semifields (leanprover-community#28494)
  feat: filtering lists and bounded quantifiers are primitive recursive (leanprover-community#26295)
  chore(Analysis/Analytic): split `Analytic.Basic` (leanprover-community#26270)
  refactor: tidy `mulVec` and `vecMul` lemmas about `•` (leanprover-community#28450)
  feat(Order/WellFounded): Acc and infinite descending chain (leanprover-community#28120)
  feat(NumberTheory/Padics): {Int,Rat}.padicValuation (leanprover-community#27667)
  chore(*): address a few timeout-related porting notes (leanprover-community#28483)
  feat(Algebra): toAlgebra_algebraMap (leanprover-community#28238)
  feat(Shrink): `IsCancelMul` instance (leanprover-community#28407)
  chore(Geometry): golf entire `chart_eq'` and `orthogonalProjection_orthogonalProjection` (leanprover-community#28485)
  feat: shifted geometric series and a `ProbabilityMeasure` version of `measure_iUnion_le` (leanprover-community#28087)
  chore(LinearAlgebra/PiTensorProduct): `rw` away use of `erw` in `lifts_zero` (leanprover-community#27554)
  feat(RingTheory): faithfully flat ring maps (leanprover-community#24530)
  chore(Geometry/RingedSpace): remove use of `erw` in `stalkSpecializes_stalkMap` (leanprover-community#27656)
  chore: add the Brownian motion project to downstream_repos.yml (leanprover-community#28459)
  feat(CategoryTheory/Sites/SheafOfTypes): composition of a sheaf with uliftFunctor is still a sheaf (leanprover-community#27816)
  feat(Valuation/DiscreteValuationRel): val relations with compatible valuations to Zm0 are IsDiscrete (leanprover-community#27213)
  chore(*): process a bunch of `aesop`-related porting notes (leanprover-community#28402)
  feat(CategoryTheory): abstract argument for the stability under transfinite compositions (leanprover-community#26030)
  chore: bump toolchain to v4.23.0-rc2 (leanprover-community#28454)
  chore(FieldTheory/Finite): fermat's little theorem in Nat form (leanprover-community#27962)
  feat(Combinatorics/SimpleGraph/Paths): add theorem `SimpleGraph.Walk.IsPath.concat` (leanprover-community#27582)
  feat(Slope): slope_pos_iff_of_le and related lemmas (leanprover-community#28039)
  feat: tactic analysis framework (leanprover-community#26683)
  chore(Data/EReal): deprecate `add_pos_of_nonneg_of_pos` and `add_ne_top_iff_of_ne_bot` (duplicates) (leanprover-community#28424)
  feat(MathlibTest/FieldSimp): add a few more tests (leanprover-community#28413)
  chore(RingTheory/HahnSeries): deprecate duplicate `orderTop_add_orderTop_le_orderTop_mul` (leanprover-community#28231)
  chore(AlgebraicGeometry/IdealSheaf): deprecate duplicate `AlgebraicGeometry.Scheme.IdealSheafData.Scheme.zeroLocus_radical` (leanprover-community#28202)
  feat(Algebra/Order): ArchimedeanClass ball (leanprover-community#27885)
  chore(Geometry/RingedSpace): remove use of `erw` in `isUnit_of_isUnit_germ` (leanprover-community#27660)
  feat(SkewMonoidAlgebra): coeff_mul lemmas (leanprover-community#27255)
  chore(LinearAlgebra): golf entire `isUnit_det` (leanprover-community#28438)
  chore(FieldTheory/IntermediateField): golf entire `coe_sum` and `coe_prod` (leanprover-community#28431)
  feat: separate linter error message for empty doc-strings (leanprover-community#27895)
  feat(RingTheory/PowerSeries/Binomial): add basic lemmas, golf (leanprover-community#27497)
  ...
@riccardobrasca riccardobrasca mentioned this pull request Aug 18, 2025
Closed
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@pechersky @Paul-Lez
feat(NumberTheory/Padics): {Int,Rat}.padicValuation (leanprover-commu…
addf95c 
…nity#27667)

`padicVal{Int,Rat}` in `Valuation` form, sending to `ℤᵐ⁰`

We didn't have a valuation that mentioned Rat and Valuation together before.
On the way to show that `ℚ_[p]` (resp. `ℤ_[p]`) is equivalent to `Completion (WithVal v)` for the `v` defined here



Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
pechersky added a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
@pechersky
feat(NumberTheory/Padics): {Int,Rat}.padicValuation (leanprover-commu…
15be106 
…nity#27667)

`padicVal{Int,Rat}` in `Valuation` form, sending to `ℤᵐ⁰`

We didn't have a valuation that mentioned Rat and Valuation together before.
On the way to show that `ℚ_[p]` (resp. `ℤ_[p]`) is equivalent to `Completion (WithVal v)` for the `v` defined here



Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@faenuccio faenuccio faenuccio left review comments

@mattrobball mattrobball mattrobball left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

t-algebra Algebra (groups, rings, fields, etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pechersky @mathlib4-merge-conflict-bot @mathlib4-dependent-issues-bot @faenuccio @mattrobball @Ruben-VandeVelde