Skip to content

[Merged by Bors] - feat: locally finite finsums of C^n sections are C^n#28048

Closed
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:cn-finsum-section
Closed

[Merged by Bors] - feat: locally finite finsums of C^n sections are C^n#28048
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:cn-finsum-section

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Aug 6, 2025 •
edited
Loading

This may seem redundant in light of #27349, but is not: finsums are more convenient for use with partitions of unity:
when using them for constructing new objects, one takes a convex combination --- which uses a finsum.

Extracted from #28046, which is necessary for the construction of Riemanian metric. As such, part of the path towards geodesics and the Levi-Civita connection.

Open in Gitpod

@grunweg
feat: locally finite finsums of C^n sections are C^n
dd0b48f 
Extracted from leanprover-community#28046, which is necessary for the construction of Riemanian
metric. As such, part of the path towards geodesics and the Levi-Civita
connection.
@grunweg grunweg added the t-differential-geometry Manifolds etc label Aug 6, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Aug 6, 2025

@ocfnash You got auto-assigned #26875, which I just took over. Would you like to to review this PR instead? Hopefully, it's all very straightforward.

@grunweg grunweg mentioned this pull request Aug 6, 2025
Closed
2 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 6, 2025 •
edited
Loading

PR summary 35a5aa069a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ContMDiff.finsum_section_of_locallyFinite
+ ContMDiffAt.finsum_section_of_locallyFinite
+ ContMDiffOn.finsum_section_of_locallyFinite
+ ContMDiffWithinAt.congr'
+ ContMDiffWithinAt.finsum_section_of_locallyFinite

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg mentioned this pull request Aug 6, 2025
Closed
1 task
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Aug 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 6, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 6, 2025
sgouezel
sgouezel reviewed Aug 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 6, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Aug 6, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Aug 6, 2025

Thank you for the quick review, Ruben and Sébastien!

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Aug 6, 2025

CI passes (except for linting, which should be fine):
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Aug 6, 2025
@grunweg
feat: locally finite finsums of C^n sections are C^n (#28048)
2e65cf9 
This may seem redundant in light of #27349, but is not: `finsum`s are more convenient for use with partitions of unity:
when using them for constructing new objects, one takes a convex combination
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 6, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: locally finite finsums of C^n sections are C^n [Merged by Bors] - feat: locally finite finsums of C^n sections are C^n Aug 6, 2025
@mathlib-bors mathlib-bors bot closed this Aug 6, 2025
@grunweg grunweg deleted the cn-finsum-section branch August 6, 2025 18:19
staroperator pushed a commit to staroperator/mathlib4 that referenced this pull request Aug 8, 2025
@grunweg @staroperator
feat: locally finite finsums of C^n sections are C^n (leanprover-comm…
fa2df54 
…unity#28048)

This may seem redundant in light of leanprover-community#27349, but is not: `finsum`s are more convenient for use with partitions of unity:
when using them for constructing new objects, one takes a convex combination
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@grunweg @Paul-Lez
feat: locally finite finsums of C^n sections are C^n (leanprover-comm…
9294204 
…unity#28048)

This may seem redundant in light of leanprover-community#27349, but is not: `finsum`s are more convenient for use with partitions of unity:
when using them for constructing new objects, one takes a convex combination
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@grunweg @Paul-Lez
feat: locally finite finsums of C^n sections are C^n (leanprover-comm…
4f5c052 
…unity#28048)

This may seem redundant in light of leanprover-community#27349, but is not: `finsum`s are more convenient for use with partitions of unity:
when using them for constructing new objects, one takes a convex combination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgouezel sgouezel sgouezel left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

@ocfnash ocfnash

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grunweg @sgouezel @Ruben-VandeVelde @ocfnash