[Merged by Bors] - chore: golf the proof in #26875#28046
Closed
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: golf the proof in #26875#28046grunweg wants to merge 3 commits intoleanprover-community:masterfrom
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 3c157e7927Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
added a commit
to grunweg/mathlib4
that referenced
this pull request
Aug 6, 2025
Extracted from leanprover-community#28046, which is necessary for the construction of Riemanian metric. As such, part of the path towards geodesics and the Levi-Civita connection.
This was referenced Aug 6, 2025
Collaborator
|
This pull request has conflicts, please merge |
Collaborator
Collaborator
|
This pull request has conflicts, please merge |
The lemma does not really have mathematical content; most general ideas have been factored out. Thus, I consider the brevity a net improvement.
0ab3b47 to
ed5bcb4
Compare
Contributor
Author
|
@michaellee94 In case you're interested, here is how I would golf the smoothness lemma you added in #26875. |
Contributor
Author
|
@PatrickMassot Would you like to take a look? This is my follow-up to the PR we both reviewed. |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…nity#28046) From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
…nity#28046) From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.
FormulaRabbit81
pushed a commit
to YaelDillies/mathlib4
that referenced
this pull request
Aug 30, 2025
…nity#28046) From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.
Commits can be reviewed independently.