[Merged by Bors] - chore: restore 'cache get' logic from before #24607#26439
Closed
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: restore 'cache get' logic from before #24607#26439kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
Contributor
kim-em
commented
Jun 26, 2025
PR summary 23a77d56ebImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mattrobball
reviewed
Jun 26, 2025
| if currentCommit.exitCode == 0 then | ||
| let commit := currentCommit.stdout.trim | ||
| -- Get all PR refs that contain this commit | ||
| let prRefPattern := s!"refs/remotes/{mathlibRemoteName}/pr/*" |
Contributor
There was a problem hiding this comment.
This was broken in the scenario where you do gh checkout pr XXXXX (thought I should be doubled checked). The flag --points-at did return something.
Since this is nested, we won't pull the right cache with the logic below under these circumstances. (Hopefully I am proven wrong...)
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Jul 7, 2025
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.