Skip to content

[Merged by Bors] - chore: remove redundant show in structures#24607

Closed
JovanGerb wants to merge 1 commit intomasterfrom
Jovan-show-struct
Closed

[Merged by Bors] - chore: remove redundant show in structures#24607
JovanGerb wants to merge 1 commit intomasterfrom
Jovan-show-struct

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

Thanks to leanprover/lean4#7717, some show .. by in structures have become unnecessary.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 5, 2025

PR summary 472bfe2fad

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 5, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 5, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 6, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 6, 2025
Thanks to leanprover/lean4#7717, some `show .. by` in structures have become unnecessary.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 6, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove redundant show in structures [Merged by Bors] - chore: remove redundant show in structures May 6, 2025
@mathlib-bors mathlib-bors bot closed this May 6, 2025
@mathlib-bors mathlib-bors bot deleted the Jovan-show-struct branch May 6, 2025 11:37
riccardobrasca pushed a commit that referenced this pull request May 7, 2025
Thanks to leanprover/lean4#7717, some `show .. by` in structures have become unnecessary.
tannerduve pushed a commit that referenced this pull request May 13, 2025
Thanks to leanprover/lean4#7717, some `show .. by` in structures have become unnecessary.
kim-em added a commit to kim-em/mathlib4 that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants