[Merged by Bors] - feat: EuclideanSpace.finAddEquivProd#26086
Closed
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: EuclideanSpace.finAddEquivProd#26086grunweg wants to merge 3 commits intoleanprover-community:masterfrom
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
Contributor
Author
Comments from Original PR #25524This section contains 2 comment(s) from the original PR, excluding bot comments. @github-actions (2025-06-06 07:34 UTC): PR summary 4e5a0b1879Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
@grunweg (2025-06-06 11:46 UTC): |
PR summary bb38781a57Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
Author
|
@eric-wieser Would you like to give this a final look? Thanks! |
4 tasks
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
I need this for #25505 (to show that R^n is a submanifold of R^m for n \leq m) and for my bordism theory branch. Previous zulip discussions: - [#Is there code for X? > Product of Euclidean spaces @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Product.20of.20Euclidean.20spaces/near/500124944) - [#mathlib4 > Create `LinearIsometryEquiv` with `WithLp 2 (α × β)` and.. @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Create.20.60LinearIsometryEquiv.60.20with.20.60WithLp.202.20.28.CE.B1.20.C3.97.20.CE.B2.29.60.20and.2E.2E/near/505938119) - [#mathlib4 > Manifold structure on Moebius strip @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Manifold.20structure.20on.20Moebius.20strip/near/522156122) Co-authored-by: @peabrainiac
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Rida-Hamadani
pushed a commit
to Rida-Hamadani/mathlib4
that referenced
this pull request
Jun 24, 2025
I need this for leanprover-community#25505 (to show that R^n is a submanifold of R^m for n \leq m) and for my bordism theory branch. Previous zulip discussions: - [#Is there code for X? > Product of Euclidean spaces @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Product.20of.20Euclidean.20spaces/near/500124944) - [#mathlib4 > Create &leanprover-community#96;LinearIsometryEquiv&leanprover-community#96; with &leanprover-community#96;WithLp 2 (α × β)&leanprover-community#96; and.. @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Create.20.60LinearIsometryEquiv.60.20with.20.60WithLp.202.20.28.CE.B1.20.C3.97.20.CE.B2.29.60.20and.2E.2E/near/505938119) - [#mathlib4 > Manifold structure on Moebius strip @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Manifold.20structure.20on.20Moebius.20strip/near/522156122) Co-authored-by: @peabrainiac
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Jul 7, 2025
I need this for leanprover-community#25505 (to show that R^n is a submanifold of R^m for n \leq m) and for my bordism theory branch. Previous zulip discussions: - [#Is there code for X? > Product of Euclidean spaces @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Product.20of.20Euclidean.20spaces/near/500124944) - [#mathlib4 > Create &leanprover-community#96;LinearIsometryEquiv&leanprover-community#96; with &leanprover-community#96;WithLp 2 (α × β)&leanprover-community#96; and.. @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Create.20.60LinearIsometryEquiv.60.20with.20.60WithLp.202.20.28.CE.B1.20.C3.97.20.CE.B2.29.60.20and.2E.2E/near/505938119) - [#mathlib4 > Manifold structure on Moebius strip @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Manifold.20structure.20on.20Moebius.20strip/near/522156122) Co-authored-by: @peabrainiac
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
I need this for leanprover-community#25505 (to show that R^n is a submanifold of R^m for n \leq m) and for my bordism theory branch. Previous zulip discussions: - [#Is there code for X? > Product of Euclidean spaces @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Product.20of.20Euclidean.20spaces/near/500124944) - [#mathlib4 > Create &leanprover-community#96;LinearIsometryEquiv&leanprover-community#96; with &leanprover-community#96;WithLp 2 (α × β)&leanprover-community#96; and.. @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Create.20.60LinearIsometryEquiv.60.20with.20.60WithLp.202.20.28.CE.B1.20.C3.97.20.CE.B2.29.60.20and.2E.2E/near/505938119) - [#mathlib4 > Manifold structure on Moebius strip @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Manifold.20structure.20on.20Moebius.20strip/near/522156122) Co-authored-by: @peabrainiac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need this for #25505 (to show that R^n is a submanifold of R^m for n \leq m) and for my bordism theory branch.
Previous zulip discussions:
Co-authored-by: @peabrainiac
TODO: paste my zulip reasoning above into the PR description. I still believe my applications 1 and 2 may hold water, but 3/4 may not.
This PR continues the work from #25524.