Closed
Conversation
Co-authored-by: @peabrainiac
PR summary 4e5a0b1879Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
4 tasks
eric-wieser
reviewed
Jun 6, 2025
eric-wieser
reviewed
Jun 6, 2025
Contributor
Author
|
Thanks for the feedback. I have addressed both comments. |
Contributor
Author
|
This PR has been migrated to a fork-based workflow: #26086 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need this for #25505 (to show that R^n is a submanifold of R^m for n \leq m) and for my bordism theory branch.
Previous zulip discussions:
Co-authored-by: @peabrainiac
TODO: paste my zulip reasoning above into the PR description. I still believe my applications 1 and 2 may hold water, but 3/4 may not.