[Merged by Bors] - feat: port LinearAlgebra.TensorProduct#2539
Closed
fpvandoorn wants to merge 10 commits intomasterfrom
Closed
[Merged by Bors] - feat: port LinearAlgebra.TensorProduct#2539fpvandoorn wants to merge 10 commits intomasterfrom
fpvandoorn wants to merge 10 commits intomasterfrom
Conversation
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
It was quite smooth. I didn't have to make changes that I expect to change downstream files, so I left few porting notes. Comments that I didn't make into porting notes: * `attribute [local ext] ext` had to be changed to `attribute [local ext high] ext` * Sometimes `M ⊗ N` needed to be replaced by `M ⊗[R] N` in theorem statements. * I needed to make a few fixes in other files. I want to go through the library globally and fix this error, but I'm waiting on #1881 to get merged, because those two things would have many merge conflicts. Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was quite smooth. I didn't have to make changes that I expect to change downstream files, so I left few porting notes.
Comments that I didn't make into porting notes:
attribute [local ext] exthad to be changed toattribute [local ext high] extM ⊗ Nneeded to be replaced byM ⊗[R] Nin theorem statements.