Conversation
Also fix `.dom` → `.Dom` in the module docstring. * [`data.part`@`ee0c179cd3c8a45aa5bffbf1b41d8dbede452865`..`80c43012d26f63026d362c3aba28f3c3bafb07e6`](https://leanprover-community.github.io/mathlib-port-status/file/data/part?range=ee0c179cd3c8a45aa5bffbf1b41d8dbede452865..80c43012d26f63026d362c3aba28f3c3bafb07e6)
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
Also fix some module docstrings. * [`data.part`@`ee0c179cd3c8a45aa5bffbf1b41d8dbede452865`..`80c43012d26f63026d362c3aba28f3c3bafb07e6`](https://leanprover-community.github.io/mathlib-port-status/file/data/part?range=ee0c179cd3c8a45aa5bffbf1b41d8dbede452865..80c43012d26f63026d362c3aba28f3c3bafb07e6) * [`order.bounds.basic`@`aba57d4d3dae35460225919dcd82fe91355162f9`..`3310acfa9787aa171db6d4cba3945f6f275fe9f2`](https://leanprover-community.github.io/mathlib-port-status/file/order/bounds/basic?range=aba57d4d3dae35460225919dcd82fe91355162f9..3310acfa9787aa171db6d4cba3945f6f275fe9f2) * [`data.list.of_fn`@`fd838fdf07a83ca89fb66d30bebf6f0e02908c3f`..`bf27744463e9620ca4e4ebe951fe83530ae6949b`](https://leanprover-community.github.io/mathlib-port-status/file/data/list/of_fn?range=fd838fdf07a83ca89fb66d30bebf6f0e02908c3f..bf27744463e9620ca4e4ebe951fe83530ae6949b) * [`data.set.finite`@`1126441d6bccf98c81214a0780c73d499f6721fe`..`1f0096e6caa61e9c849ec2adbd227e960e9dff58`](https://leanprover-community.github.io/mathlib-port-status/file/data/set/finite?range=1126441d6bccf98c81214a0780c73d499f6721fe..1f0096e6caa61e9c849ec2adbd227e960e9dff58) * [`group_theory.group_action.opposite`@`fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e`..`4330aae21f538b862f8aead371cfb6ee556398f1`](https://leanprover-community.github.io/mathlib-port-status/file/group_theory/group_action/opposite?range=fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e..4330aae21f538b862f8aead371cfb6ee556398f1) * [`data.list.basic`@`cf9386b56953fb40904843af98b7a80757bbe7f9`..`1447cae870f372074e480de1acbeb51de0077698`](https://leanprover-community.github.io/mathlib-port-status/file/data/list/basic?range=cf9386b56953fb40904843af98b7a80757bbe7f9..1447cae870f372074e480de1acbeb51de0077698) * [`data.list.infix`@`6d0adfa76594f304b4650d098273d4366edeb61b`..`26f081a2fb920140ed5bc5cc5344e84bcc7cb2b2`](https://leanprover-community.github.io/mathlib-port-status/file/data/list/infix?range=6d0adfa76594f304b4650d098273d4366edeb61b..26f081a2fb920140ed5bc5cc5344e84bcc7cb2b2) * [`set_theory.lists`@`9003f28797c0664a49e4179487267c494477d853`..`497d1e06409995dd8ec95301fa8d8f3480187f4c`](https://leanprover-community.github.io/mathlib-port-status/file/set_theory/lists?range=9003f28797c0664a49e4179487267c494477d853..497d1e06409995dd8ec95301fa8d8f3480187f4c) * [`data.nat.choose.dvd`@`207cfac9fcd06138865b5d04f7091e46d9320432`..`966e0cf0685c9cedf8a3283ac69eef4d5f2eaca2`](https://leanprover-community.github.io/mathlib-port-status/file/data/nat/choose/dvd?range=207cfac9fcd06138865b5d04f7091e46d9320432..966e0cf0685c9cedf8a3283ac69eef4d5f2eaca2)
|
Pull request successfully merged into master. Build succeeded:
|
eric-wieser
reviewed
Feb 27, 2023
| #align semigroup.opposite_smul_comm_class' Semigroup.opposite_smulCommClass' | ||
| #align add_semigroup.opposite_vadd_comm_class' AddSemigroup.opposite_vaddCommClass' | ||
|
|
||
| @[to_additive] |
Member
There was a problem hiding this comment.
@YaelDillies already had a PR for this, #2344. I think probably your version generates the wrong name, so we still need that PR.
Member
There was a problem hiding this comment.
Also, this PR forgot to add the #align.
eric-wieser
reviewed
Feb 27, 2023
Comment on lines
+346
to
+358
| lemma dropSlice_sublist (n m : ℕ) (l : List α) : l.dropSlice n m <+ l := | ||
| calc l.dropSlice n m = take n l ++ drop m (drop n l) := by rw [dropSlice_eq, drop_drop, add_comm] | ||
| _ <+ take n l ++ drop n l := (Sublist.refl _).append (drop_sublist _ _) | ||
| _ = _ := take_append_drop _ _ | ||
| #align list.slice_sublist List.dropSlice_sublist | ||
|
|
||
| lemma dropSlice_subset (n m : ℕ) (l : List α) : l.dropSlice n m ⊆ l := | ||
| (dropSlice_sublist n m l).subset | ||
| #align list.slice_subset List.dropSlice_subset | ||
|
|
||
| lemma mem_of_mem_dropSlice {n m : ℕ} {l : List α} {a : α} (h : a ∈ l.dropSlice n m) : a ∈ l := | ||
| dropSlice_subset n m l h | ||
| #align list.mem_of_mem_slice List.mem_of_mem_dropSlice |
This was referenced Feb 27, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
The SHA was already updated in #2498, but the `#align` was forgotten, and the instance name was incorrectly generated. Match leanprover-community/mathlib3#16975. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
YaelDillies
reviewed
Mar 17, 2023
Comment on lines
+244
to
+250
| @[simp] | ||
| theorem pairwise_ofFn {R : α → α → Prop} {n} {f : Fin n → α} : | ||
| (ofFn f).Pairwise R ↔ ∀ ⦃i j⦄, i < j → R (f i) (f j) := by | ||
| simp only [pairwise_iff_get, (Fin.cast (length_ofFn f)).surjective.forall, get_ofFn, | ||
| OrderIso.lt_iff_lt] | ||
| #align list.pairwise_of_fn List.pairwise_ofFn | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix some module docstrings.
data.part@ee0c179cd3c8a45aa5bffbf1b41d8dbede452865..80c43012d26f63026d362c3aba28f3c3bafb07e6order.bounds.basic@aba57d4d3dae35460225919dcd82fe91355162f9..3310acfa9787aa171db6d4cba3945f6f275fe9f2data.list.of_fn@fd838fdf07a83ca89fb66d30bebf6f0e02908c3f..bf27744463e9620ca4e4ebe951fe83530ae6949bdata.set.finite@1126441d6bccf98c81214a0780c73d499f6721fe..1f0096e6caa61e9c849ec2adbd227e960e9dff58group_theory.group_action.opposite@fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e..4330aae21f538b862f8aead371cfb6ee556398f1data.list.basic@cf9386b56953fb40904843af98b7a80757bbe7f9..1447cae870f372074e480de1acbeb51de0077698data.list.infix@6d0adfa76594f304b4650d098273d4366edeb61b..26f081a2fb920140ed5bc5cc5344e84bcc7cb2b2set_theory.lists@9003f28797c0664a49e4179487267c494477d853..497d1e06409995dd8ec95301fa8d8f3480187f4cdata.nat.choose.dvd@207cfac9fcd06138865b5d04f7091e46d9320432..966e0cf0685c9cedf8a3283ac69eef4d5f2eaca2