Skip to content

feat: Link list.pairwise, list.of_fn#1762

Closed
YaelDillies wants to merge 8 commits intomasterfrom
chain_length
Closed

feat: Link list.pairwise, list.of_fn#1762
YaelDillies wants to merge 8 commits intomasterfrom
chain_length

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label Jan 22, 2023
@kbuzzard
Copy link
Copy Markdown
Member

I don't understand why this PR doesn't have pairwise_of_fn in it.

@YaelDillies
Copy link
Copy Markdown
Contributor Author

Sorry, it just wasn't updated (and not marked awaiting-review).

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

I think it's better not to make stylistic changes on top of the mathport output beyond the ones made in start_port.sh

@bors
Copy link
Copy Markdown

bors bot commented Feb 17, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kim-em kim-em added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Feb 17, 2023
@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 27, 2023
@YaelDillies YaelDillies removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 17, 2023
@YaelDillies
Copy link
Copy Markdown
Contributor Author

This was already forward-ported in #2498.

@YaelDillies YaelDillies deleted the chain_length branch March 17, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged

Projects

No open projects
Status: SHA added

Development

Successfully merging this pull request may close these issues.

4 participants