[Merged by Bors] - fix(Linter/DeprecatedModule): tweak deprecated_module syntax#24032
Closed
[Merged by Bors] - fix(Linter/DeprecatedModule): tweak deprecated_module syntax#24032
deprecated_module syntax#24032Conversation
PR #24027 removes the need to disable the header linter before module deprecations.
…module_colon_equal
PR summary e2bb3f9457Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
1 task
…module_colon_equal
…module_colon_equal
Contributor
|
LGTM (and sorry for the delay, I temporarily forgot that this PR also needs to be approved...) |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
deprecated_module syntax
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
|
Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
I forgot the `:=` part of the `deprecated` syntax: the new syntax `deprecated_module "Optional string here with further details" (since := "yyyy-mm-dd")` matches the syntax of the `deprecated` attribute. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
deprecated_module syntaxdeprecated_module syntax
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
I forgot the `:=` part of the `deprecated` syntax: the new syntax `deprecated_module "Optional string here with further details" (since := "yyyy-mm-dd")` matches the syntax of the `deprecated` attribute. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot the
:=part of thedeprecatedsyntax: the new syntaxdeprecated_module "Optional string here with further details" (since := "yyyy-mm-dd")matches the syntax of the
deprecatedattribute.