[Merged by Bors] - fix(deprecated module): automatically disable the header linter#24027
Closed
[Merged by Bors] - fix(deprecated module): automatically disable the header linter#24027
Conversation
PR summary f1b0853ecaImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
|
Thanks for doing this; I was considering to create this Pr myself! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
This PR makes the `header` linter silent if the first non-import command of a file is `deprecated_module`. [Zulip#mathlib4 > `Deprecated` folder @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60Deprecated.60.20folder/near/511986519)
grunweg
added a commit
that referenced
this pull request
Apr 14, 2025
PR #24027 removes the need to disable the header linter before module deprecations.
This was referenced Apr 14, 2025
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
PR #24027 removes the need to disable the header linter before module deprecations. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
This PR makes the `header` linter silent if the first non-import command of a file is `deprecated_module`. [Zulip#mathlib4 > `Deprecated` folder @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60Deprecated.60.20folder/near/511986519)
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
PR #24027 removes the need to disable the header linter before module deprecations. Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
headerlinter silent if the first non-import command of a file isdeprecated_module.Zulip#mathlib4 > `Deprecated` folder @ 💬