[Merged by Bors] - feat(Data/Finsupp/Basic): add Finsupp.(un)curry_single and @[simps] to Finsupp.finsuppProd(L)Equiv#23021
Closed
101damnations wants to merge 8 commits intomasterfrom
Closed
[Merged by Bors] - feat(Data/Finsupp/Basic): add Finsupp.(un)curry_single and @[simps] to Finsupp.finsuppProd(L)Equiv#23021101damnations wants to merge 8 commits intomasterfrom
Finsupp.(un)curry_single and @[simps] to Finsupp.finsuppProd(L)Equiv#23021101damnations wants to merge 8 commits intomasterfrom
Conversation
PR summary cfd58948ddImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
4 tasks
Vierkantor
reviewed
Apr 22, 2025
Contributor
|
✌️ 101damnations can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
|
Please consider moving some or all of the description above the Generally, the bit below the |
Collaborator
|
This pull request has conflicts, please merge |
added 2 commits
May 8, 2025 13:38
added 3 commits
May 8, 2025 14:44
This reverts commit 5501e95.
Collaborator
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 8, 2025
…]` to `Finsupp.finsuppProd(L)Equiv` (#23021) This was raised by @Whysoserioushah regarding #21732. We add `Finsupp.uncurry_apply`, which simplifies `Finsupp.uncurry` applied to a term of a product type `xy : α × β`, to prevent `Basis.smulTower_repr` breaking. However, we don't tag this with `@[simp]`; there is already a `@[simp]` tag on the less eager `Finsupp.uncurry_apply_pair`, which applies to a pair of terms `x : α`, `y : β`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Finsupp.(un)curry_single and @[simps] to Finsupp.finsuppProd(L)EquivFinsupp.(un)curry_single and @[simps] to Finsupp.finsuppProd(L)Equiv
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
…]` to `Finsupp.finsuppProd(L)Equiv` (#23021) This was raised by @Whysoserioushah regarding #21732. We add `Finsupp.uncurry_apply`, which simplifies `Finsupp.uncurry` applied to a term of a product type `xy : α × β`, to prevent `Basis.smulTower_repr` breaking. However, we don't tag this with `@[simp]`; there is already a `@[simp]` tag on the less eager `Finsupp.uncurry_apply_pair`, which applies to a pair of terms `x : α`, `y : β`.
bwehlin
pushed a commit
to bwehlin/mathlib4
that referenced
this pull request
May 31, 2025
…]` to `Finsupp.finsuppProd(L)Equiv` (leanprover-community#23021) This was raised by @Whysoserioushah regarding leanprover-community#21732. We add `Finsupp.uncurry_apply`, which simplifies `Finsupp.uncurry` applied to a term of a product type `xy : α × β`, to prevent `Basis.smulTower_repr` breaking. However, we don't tag this with `@[simp]`; there is already a `@[simp]` tag on the less eager `Finsupp.uncurry_apply_pair`, which applies to a pair of terms `x : α`, `y : β`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was raised by @Whysoserioushah regarding #21732. We add
Finsupp.uncurry_apply, which simplifiesFinsupp.uncurryapplied to a term of a product typexy : α × β, to preventBasis.smulTower_reprbreaking. However, we don't tag this with@[simp]; there is already a@[simp]tag on the less eagerFinsupp.uncurry_apply_pair, which applies to a pair of termsx : α,y : β.(Original comment: Adding the lemmas and
@[simps]on their own breaks this lemma and the simplest way to fix it (and justify removingFinsupp.finsuppProdLEquiv_symm_apply) is to make the argument toFinsupp.uncurry_apply_pair(added in #22939) any term of the product type, but maybe that would be too eager a simp lemma?)