Skip to content

[Merged by Bors] - refactor(Data/Finsupp/Basic): Extract Finsupp.curry_uncurry#22939

Closed
BoltonBailey wants to merge 7 commits intomasterfrom
BoltonBailey/finsupp-curry-uncurry
Closed

[Merged by Bors] - refactor(Data/Finsupp/Basic): Extract Finsupp.curry_uncurry#22939
BoltonBailey wants to merge 7 commits intomasterfrom
BoltonBailey/finsupp-curry-uncurry

Conversation

@BoltonBailey
Copy link
Copy Markdown
Collaborator

@BoltonBailey BoltonBailey commented Mar 14, 2025 •
edited
Loading

Refactors the finsuppProdEquiv definition so that the inverse laws are now separate (simp) lemmas: Finsupp.curry_uncurry and Finsupp.uncurry_curry. Also factors out Finsupp.uncurry_apply_pair as a prerequisite to these.

Open in Gitpod

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Mar 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2025 •
edited
Loading

PR summary 64fb86e792

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ curry_uncurry
+ uncurry_apply_pair
+ uncurry_curry

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@BoltonBailey BoltonBailey changed the title refactor: Extract curry_uncurry refactor(Data/Finsupp/Basic): Extract Finsupp.curry_uncurry Mar 14, 2025
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Mar 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 14, 2025
@urkud
Copy link
Copy Markdown
Member

urkud commented Mar 17, 2025

Thanks! 🎉
bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 17, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 17, 2025
@BoltonBailey
refactor(Data/Finsupp/Basic): Extract Finsupp.curry_uncurry (#22939)
d27bbba 
Refactors the `finsuppProdEquiv` definition so that the inverse laws are now separate (simp) lemmas: `Finsupp.curry_uncurry` and `Finsupp.uncurry_curry`. Also factors out `Finsupp.uncurry_apply_pair` as a prerequisite to these.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 17, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Data/Finsupp/Basic): Extract Finsupp.curry_uncurry [Merged by Bors] - refactor(Data/Finsupp/Basic): Extract Finsupp.curry_uncurry Mar 17, 2025
@mathlib-bors mathlib-bors bot closed this Mar 17, 2025
@mathlib-bors mathlib-bors bot deleted the BoltonBailey/finsupp-curry-uncurry branch March 17, 2025 03:27
@101damnations 101damnations mentioned this pull request Mar 17, 2025
Closed
tukamilano pushed a commit that referenced this pull request Mar 20, 2025
@BoltonBailey @tukamilano
refactor(Data/Finsupp/Basic): Extract Finsupp.curry_uncurry (#22939)
8d43380 
Refactors the `finsuppProdEquiv` definition so that the inverse laws are now separate (simp) lemmas: `Finsupp.curry_uncurry` and `Finsupp.uncurry_curry`. Also factors out `Finsupp.uncurry_apply_pair` as a prerequisite to these.
@BoltonBailey BoltonBailey mentioned this pull request Jul 16, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BoltonBailey @urkud @Ruben-VandeVelde