[Merged by Bors] - chore: update hash for Group/Units for is_add_unit.decidable#2278
Closed
[Merged by Bors] - chore: update hash for Group/Units for is_add_unit.decidable#2278
Conversation
Contributor
pechersky
commented
Feb 14, 2023
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Feb 14, 2023
Missing `to_additive` I had actually added this to mathlib4 3 months ago in leanprover-community/mathlib4@cbc0834 (leanprover-community/mathlib4#549), and never noticed it wasn't in mathlib3. mathlib4 hash-update placeholder pr: leanprover-community/mathlib4#2278
eric-wieser
approved these changes
Feb 27, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Can you forward-port the to_additive docstring too? It seems to be missing.
Member
|
Nevermind, I added it myself. bors d+ |
|
✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.