This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(algebra/group/units): is_add_unit.decidable#18439
Closed
[Merged by Bors] - chore(algebra/group/units): is_add_unit.decidable#18439
Conversation
Missing `to_additive` I had actually added this to mathlib4 3 months ago, never noticed it wasn't in mathlib3
eric-wieser
approved these changes
Feb 14, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Thanks!
bors d+
Can you find the corresponding mathlib4 PR or commit and include a reference to it in the description?
Please also create a placeholder mathlib4 PR to forward-port the SHA change.
|
✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
Missing `to_additive` I had actually added this to mathlib4 3 months ago in leanprover-community/mathlib4@cbc0834 (leanprover-community/mathlib4#549), and never noticed it wasn't in mathlib3. mathlib4 hash-update placeholder pr: leanprover-community/mathlib4#2278
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing
to_additiveI had actually added this to mathlib4 3 months ago in leanprover-community/mathlib4@cbc0834 (leanprover-community/mathlib4#549), and never noticed it wasn't in mathlib3.
mathlib4 hash-update placeholder pr: leanprover-community/mathlib4#2278