Skip to content

[Merged by Bors] - refactor(RepresentationTheory/GroupCohomology/LowDegree): make nCoboundaries a submodule of the n-cochains rather than the nCocycles for n = 0, 1, 2#22047

Closed
101damnations wants to merge 14 commits intomasterfrom
arlgpcohlowdeg3
Closed

[Merged by Bors] - refactor(RepresentationTheory/GroupCohomology/LowDegree): make nCoboundaries a submodule of the n-cochains rather than the nCocycles for n = 0, 1, 2#22047
101damnations wants to merge 14 commits intomasterfrom
arlgpcohlowdeg3

Conversation

@101damnations
Copy link
Copy Markdown
Collaborator

@101damnations 101damnations commented Feb 18, 2025

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 18, 2025

PR summary 51a0d2ac96

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ dOne_apply_mem_twoCocycles
+ dZero_apply_mem_oneCocycles
+ instance : FunLike (oneCoboundaries A) G A := ⟨Subtype.val, Subtype.val_injective⟩
+ instance : FunLike (twoCoboundaries A) (G × G) A := ⟨Subtype.val, Subtype.val_injective⟩
+ isMulOneCoboundary_of_mem_oneCoboundaries
+ isMulOneCocycle_of_mem_oneCocycles
+ isMulTwoCoboundary_of_mem_twoCoboundaries
+ isMulTwoCocycle_of_mem_twoCocycles
+ isOneCoboundary_of_mem_oneCoboundaries
+ isOneCocycle_of_mem_oneCocycles
+ isTwoCoboundary_of_mem_twoCoboundaries
+ isTwoCocycle_of_mem_twoCocycles
+ oneCoboundaries.coe_mk
+ oneCoboundaries.val_eq_coe
+ oneCoboundariesToOneCocycles
+ oneCoboundariesToOneCocycles_apply
+ oneCoboundaries_ext
+ oneCoboundaries_le_oneCocycles
+ twoCoboundaries.coe_mk
+ twoCoboundaries.val_eq_coe
+ twoCoboundariesToTwoCocycles
+ twoCoboundariesToTwoCocycles_apply
+ twoCoboundaries_ext
+ twoCoboundaries_le_twoCocycles
- isMulOneCoboundary_of_oneCoboundaries
- isMulOneCocycle_of_oneCocycles
- isMulTwoCoboundary_of_twoCoboundaries
- isMulTwoCocycle_of_twoCocycles
- isOneCoboundary_of_oneCoboundaries
- isOneCocycle_of_oneCocycles
- isTwoCoboundary_of_twoCoboundaries
- isTwoCocycle_of_twoCocycles
- mem_oneCoboundaries_iff
- mem_range_of_mem_oneCoboundaries
- mem_range_of_mem_twoCoboundaries
- mem_twoCoboundaries_iff
- oneCoboundariesOfEq
- oneCoboundariesOfEq_apply
- oneCoboundariesOfMemRange
- oneCoboundaries_of_mem_range_apply
- twoCoboundariesOfEq
- twoCoboundariesOfEq_apply
- twoCoboundariesOfMemRange
- twoCoboundariesOfMemRange_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 18, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Feb 18, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@riccardobrasca
Copy link
Copy Markdown
Member

I agree this is an improvement, thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 19, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 19, 2025
…undaries` a submodule of the n-cochains rather than the `nCocycles` for `n = 0, 1, 2` (#22047)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 19, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(RepresentationTheory/GroupCohomology/LowDegree): make nCoboundaries a submodule of the n-cochains rather than the nCocycles for n = 0, 1, 2 [Merged by Bors] - refactor(RepresentationTheory/GroupCohomology/LowDegree): make nCoboundaries a submodule of the n-cochains rather than the nCocycles for n = 0, 1, 2 Feb 19, 2025
@mathlib-bors mathlib-bors bot closed this Feb 19, 2025
@mathlib-bors mathlib-bors bot deleted the arlgpcohlowdeg3 branch February 19, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants