Skip to content

[Merged by Bors] - refactor(RepresentationTheory/GroupCohomology/LowDegree): define Hn using ShortComplex.moduleCatHomology for n = 0, 1, 2#22046

Closed
101damnations wants to merge 7 commits intomasterfrom
arlgpcohlowdeg2
Closed

[Merged by Bors] - refactor(RepresentationTheory/GroupCohomology/LowDegree): define Hn using ShortComplex.moduleCatHomology for n = 0, 1, 2#22046
101damnations wants to merge 7 commits intomasterfrom
arlgpcohlowdeg2

Conversation

@101damnations
Copy link
Copy Markdown
Collaborator


Up to defeq we're essentially just adding some ModuleCat.of, ModuleCat.ofHoms, but this makes it a little easier to utilise the ShortComplex API when convenient.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary ce7204a92f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ H1LequivOfIsTrivial_comp_H1π
+ H1π
+ H1π_eq_zero_iff
+ H2π
+ H2π_eq_zero_iff
+ dZero_comp_subtype
- H1LequivOfIsTrivial_comp_H1_π
- H1_π
- H2_π
- dZero_comp_H0_subtype

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
1316 -2 erw

Current commit ce7204a92f
Reference commit 971ebb0f1b

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 18, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 18, 2025
… using `ShortComplex.moduleCatHomology` for `n = 0, 1, 2` (#22046)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 18, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(RepresentationTheory/GroupCohomology/LowDegree): define Hn using ShortComplex.moduleCatHomology for n = 0, 1, 2 [Merged by Bors] - refactor(RepresentationTheory/GroupCohomology/LowDegree): define Hn using ShortComplex.moduleCatHomology for n = 0, 1, 2 Feb 18, 2025
@mathlib-bors mathlib-bors bot closed this Feb 18, 2025
@mathlib-bors mathlib-bors bot deleted the arlgpcohlowdeg2 branch February 18, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants