Skip to content

[Merged by Bors] - feat(CategoryTheory): various properties of transfinite compositions#21843

Closed
joelriou wants to merge 13 commits intomasterfrom
transfinite-compositions-misc
Closed

[Merged by Bors] - feat(CategoryTheory): various properties of transfinite compositions#21843
joelriou wants to merge 13 commits intomasterfrom
transfinite-compositions-misc

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Feb 13, 2025

Some more basic API for transfinite compositions and relative cell complexes is added. It is also shown that isomorphisms are stable under transfinite compositions.

After this, it will be possible to start proving the main results of the small object argument.


Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Feb 13, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Feb 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 13, 2025

PR summary b391f4b28d

Import changes exceeding 2%

% File
+8.90% Mathlib.CategoryTheory.Limits.Shapes.Preorder.TransfiniteCompositionOfShape
+8.67% Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Limits.Shapes.Preorder.TransfiniteCompositionOfShape 663 722 +59 (+8.90%)
Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition 669 727 +58 (+8.67%)
Mathlib.AlgebraicTopology.RelativeCellComplex.Basic 748 760 +12 (+1.60%)
Import changes for all files
Files Import difference
Mathlib.CategoryTheory.SmallObject.TransfiniteIteration 4
Mathlib.CategoryTheory.SmallObject.TransfiniteCompositionLifting 10
Mathlib.Topology.CWComplex.Abstract.Basic 11
Mathlib.AlgebraicTopology.RelativeCellComplex.Basic 12
Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition 58
Mathlib.CategoryTheory.Limits.Shapes.Preorder.TransfiniteCompositionOfShape 59

Declarations diff

+ instance (j : J) : HasIterationOfShape (Set.Iic j) C
+ instance (j : J) : IsIso (h.incl.app j)
+ instance : (isomorphisms C).IsStableUnderTransfiniteComposition
+ instance {j : J} (g : ⊥ ⟶ j) : IsIso (h.F.map g) := by
+ instance {j j' : J} (f : j ⟶ j') : IsIso (h.F.map f)
+ isIso
+ ofArrowIso
+ reindex
+ transfiniteCompositionOfShape
+ transfiniteCompositionsOfShape_map_of_preserves
++ iic
++ map

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 13, 2025
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but of course of course first get #21849 merged before you merge this.
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 14, 2025

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 14, 2025
@joelriou joelriou added the WIP Work in progress label Feb 14, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 15, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@joelriou joelriou removed the WIP Work in progress label Feb 15, 2025
@joelriou
Copy link
Copy Markdown
Contributor Author

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 15, 2025
…21843)

Some more basic API for transfinite compositions and relative cell complexes is added. It is also shown that isomorphisms are stable under transfinite compositions.

After this, it will be possible to start proving the main results of the small object argument.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): various properties of transfinite compositions [Merged by Bors] - feat(CategoryTheory): various properties of transfinite compositions Feb 15, 2025
@mathlib-bors mathlib-bors bot closed this Feb 15, 2025
@mathlib-bors mathlib-bors bot deleted the transfinite-compositions-misc branch February 15, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants