Skip to content

[Merged by Bors] - feat(Order/Interval): Order.succ on Set.Iic#21849

Closed
joelriou wants to merge 3 commits intomasterfrom
interval-set-succ-order
Closed

[Merged by Bors] - feat(Order/Interval): Order.succ on Set.Iic#21849
joelriou wants to merge 3 commits intomasterfrom
interval-set-succ-order

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Feb 13, 2025 •
edited
Loading

In this PR, it shown that ↑(Order.succ i) = Order.succ ↑i when i is a non maximal element of Set.Iic j.

Open in Gitpod

@joelriou joelriou added the t-order Order theory label Feb 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 13, 2025 •
edited
Loading

PR summary 50653d9eae

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Order.Interval.Set.SuccOrder (new file) 387

Declarations diff

+ Ici.coe_pred_of_not_isMin
+ Ici.pred_eq_of_not_isMin
+ Iic.coe_succ_of_not_isMax
+ Iic.succ_eq_of_not_isMax

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

This was referenced Feb 13, 2025
Closed
Closed
@vihdzp
Copy link
Copy Markdown
Collaborator

vihdzp commented Feb 13, 2025

I think the result might be slightly more useful if you phrase it as Order.succ i = ⟨Order.succ i.1, _⟩.

@b-mehta
Copy link
Copy Markdown
Contributor

b-mehta commented Feb 14, 2025

Let's just have both, I'd say: they both have their use-cases.

@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Feb 14, 2025

I have added the variant Iic.succ_eq_of_not_isMax.

vihdzp
vihdzp reviewed Feb 14, 2025
View reviewed changes
@joelriou joelriou mentioned this pull request Feb 14, 2025
Closed
2 tasks
TwoFX
TwoFX approved these changes Feb 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 15, 2025
@joelriou
feat(Order/Interval): Order.succ on Set.Iic (#21849)
a851840 
In this PR, it shown that `↑(Order.succ i) = Order.succ ↑i` when `i` is a non maximal element of `Set.Iic j`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order/Interval): Order.succ on Set.Iic [Merged by Bors] - feat(Order/Interval): Order.succ on Set.Iic Feb 15, 2025
@mathlib-bors mathlib-bors bot closed this Feb 15, 2025
@mathlib-bors mathlib-bors bot deleted the interval-set-succ-order branch February 15, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

+1 more reviewer

@vihdzp vihdzp vihdzp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelriou @vihdzp @b-mehta @TwoFX