[Merged by Bors] - feat(AlgebraicTopology): relative cell complexes, refactor of CW-complexes#21600
Closed
[Merged by Bors] - feat(AlgebraicTopology): relative cell complexes, refactor of CW-complexes#21600
Conversation
PR summary 726138d611Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.CWComplex.Abstract.Basic | 1936 | 1989 | +53 (+2.74%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Topology.CWComplex.Abstract.Basic |
53 |
Mathlib.AlgebraicTopology.RelativeCellComplex.Basic (new file) |
748 |
Declarations diff
+ Cells
+ Cells.i
+ Cells.ι
+ RelativeCellComplex
+ basicCell
+ diskBoundary
+ diskBoundaryInclusion
+ hom_ext
- AttachCells
- AttachGeneralizedCells
- AttachGeneralizedCells.inclusion
- instance : Coe RelativeCWComplex TopCat where coe X := toTopCat X
- skInclusion
- sphereInclusion
- toTopCat
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Co-authored-by: Nick Ward <102917377+gio256@users.noreply.github.com>
Co-authored-by: Nick Ward <102917377+gio256@users.noreply.github.com>
21 tasks
jzxia
reviewed
Feb 11, 2025
Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
Collaborator
|
This PR/issue depends on:
|
Co-authored-by: Jiazhen Xia <6234949+jzxia@users.noreply.github.com>
joelriou
commented
Feb 12, 2025
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
…lexes (#21600) A structure `RelativeCellComplex` is introduced. It is used here in order to refactor the definition of CW-complexes. It shall also be used in the formalization of the small object argument. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
joneugster
pushed a commit
that referenced
this pull request
Feb 12, 2025
…lexes (#21600) A structure `RelativeCellComplex` is introduced. It is used here in order to refactor the definition of CW-complexes. It shall also be used in the formalization of the small object argument. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A structure
RelativeCellComplexis introduced. It is used here in order to refactor the definition of CW-complexes.It shall also be used in the formalization of the small object argument.