[Merged by Bors] - feat(AlgebraicTopology): attaching cells#21613
Closed
[Merged by Bors] - feat(AlgebraicTopology): attaching cells#21613
Conversation
PR summary 14a778aecfImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.CategoryTheory.SmallObject.Construction | 424 | 617 | +193 (+45.52%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.CategoryTheory.SmallObject.Construction |
193 |
Mathlib.AlgebraicTopology.RelativeCellComplex.AttachCells (new file) |
616 |
Declarations diff
+ AttachCells
+ attachCellsιFunctorObj
+ cell
+ cell_def
+ hom_ext
+ nonempty_attachCells_iff
+ pushouts_coproducts
+ reindexCellTypes
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
gio256
reviewed
Feb 9, 2025
Co-authored-by: Nick Ward <102917377+gio256@users.noreply.github.com>
Co-authored-by: Nick Ward <102917377+gio256@users.noreply.github.com>
21 tasks
TwoFX
reviewed
Feb 11, 2025
Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
Given a family of morphisms `g a : A a ⟶ B a` and a morphism `f : X₁ ⟶ X₂`, this PR introduces a structure `AttachCells g f` which expresses that `X₂` is obtained from `X₁` by attaching cells of the form `g a`. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
joneugster
pushed a commit
that referenced
this pull request
Feb 12, 2025
Given a family of morphisms `g a : A a ⟶ B a` and a morphism `f : X₁ ⟶ X₂`, this PR introduces a structure `AttachCells g f` which expresses that `X₂` is obtained from `X₁` by attaching cells of the form `g a`. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a family of morphisms
g a : A a ⟶ B aand a morphismf : X₁ ⟶ X₂, this PR introduces a structureAttachCells g fwhich expresses thatX₂is obtained fromX₁by attaching cells of the formg a.I think the
large-importwarning can be ignored: the extra import toSmallObject.Constructionis needed in order to phrase an important property of the construction that is done in this file, and it shall be used in the downstream uses of this construction.