Skip to content

[Merged by Bors] - feat: FunLike instance for HilbertBasis#21440

Closed
eric-wieser wants to merge 11 commits intomasterfrom
eric-wieser/l2-ext
Closed

[Merged by Bors] - feat: FunLike instance for HilbertBasis#21440
eric-wieser wants to merge 11 commits intomasterfrom
eric-wieser/l2-ext

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Feb 4, 2025 •
edited by riccardobrasca
Loading

Hilbert bases are equal iff their elements are equal.

This is obtained from a more general ext lemma for continuous additive maps from lp.

Many helper lemmas for lp.single are added / generalized / golfed along the way.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2025 •
edited
Loading

PR summary bad0c316b6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coeFnAddMonoidHom
+ coeFnAddMonoidHom_apply
+ coeFn_single
+ ext_continuousAddMonoidHom
+ ext_continuousLinearMap
+ instFunLike
+ isometry_single
+ lsingle
+ singleAddMonoidHom
+ singleContinuousAddMonoidHom
+ singleContinuousAddMonoidHom_apply
+ singleContinuousLinearMap
+ singleContinuousLinearMap_apply
+ single_add
+ single_sub
+ single_zero
- instCoeFun

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Feb 4, 2025
@eric-wieser eric-wieser mentioned this pull request Feb 4, 2025
Closed
@eric-wieser eric-wieser mentioned this pull request Feb 5, 2025
Closed
@eric-wieser eric-wieser marked this pull request as ready for review February 5, 2025 04:29
@eric-wieser eric-wieser requested a review from j-loreaux February 9, 2025 07:00
@eric-wieser eric-wieser changed the title feat: ext for continuous additive maps from lp feat: FunLike instance for HilbertBasis Feb 12, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Feb 12, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Feb 12, 2025

This PR/issue depends on:

j-loreaux
j-loreaux reviewed Feb 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 14, 2025

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 14, 2025
eric-wieser and others added 3 commits February 14, 2025 13:58
@eric-wieser @j-loreaux
Apply suggestions from code review
7eaaf17 
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@eric-wieser
reorder
0d48032
@eric-wieser
tidy
bad0c31
@eric-wieser
Copy link
Copy Markdown
Member Author

eric-wieser commented Feb 14, 2025

Thanks for the cleanup!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2025
@eric-wieser
feat: FunLike instance for HilbertBasis (#21440)
adf649c 
Hilbert bases are equal iff their elements are equal.

This is obtained from a more general `ext` lemma for continuous additive maps from `lp`.

Many helper lemmas for `lp.single` are added / generalized / golfed along the way.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: FunLike instance for HilbertBasis [Merged by Bors] - feat: FunLike instance for HilbertBasis Feb 14, 2025
@mathlib-bors mathlib-bors bot closed this Feb 14, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser/l2-ext branch February 14, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-loreaux j-loreaux j-loreaux left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eric-wieser @mathlib4-dependent-issues-bot @j-loreaux