Skip to content

[Merged by Bors] - refactor(lpSpace): reorder type arguments#21779

Closed
eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser/move-lp-variables
Closed

[Merged by Bors] - refactor(lpSpace): reorder type arguments#21779
eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser/move-lp-variables

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Feb 12, 2025

When talking about a 𝕜-module E, the (unwritten) convention is to order the arguments as 𝕜 E not E 𝕜.

One proof using @ breaks, but this proof didn't need @ in the first place.


Open in Gitpod

@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label Feb 12, 2025
@github-actions
Copy link
Copy Markdown

PR summary 9c5188859b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 12, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 12, 2025
When talking about a `𝕜`-module `E`, the (unwritten) convention is to order the arguments as `𝕜 E` not `E 𝕜`.

One proof using `@` breaks, but this proof didn't need `@` in the first place.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(lpSpace): reorder type arguments [Merged by Bors] - refactor(lpSpace): reorder type arguments Feb 12, 2025
@mathlib-bors mathlib-bors bot closed this Feb 12, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser/move-lp-variables branch February 12, 2025 12:37
joneugster pushed a commit that referenced this pull request Feb 12, 2025
When talking about a `𝕜`-module `E`, the (unwritten) convention is to order the arguments as `𝕜 E` not `E 𝕜`.

One proof using `@` breaks, but this proof didn't need `@` in the first place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants