Skip to content

[Merged by Bors] - feat(Data/Matroid/Circuit): better junk values for fundCircuit#21240

Closed
apnelson1 wants to merge 4 commits intomasterfrom
fundCircuit_junk
Closed

[Merged by Bors] - feat(Data/Matroid/Circuit): better junk values for fundCircuit#21240
apnelson1 wants to merge 4 commits intomasterfrom
fundCircuit_junk

Conversation

@apnelson1
Copy link
Copy Markdown
Collaborator

@apnelson1 apnelson1 commented Jan 29, 2025

The definition of fundamental circuits in #21145 was suboptimal, in that its junk values were unstable. We slightly modify the definition so that the fundamental circuit of a non-element e of the ground set is a singleton {e}.

This removes assumptions from a couple of existing lemmas, and crucially makes the useful lemma Matroid.fundCircuit_restrict_univ true, where it wasn't before.

Open in Gitpod

@apnelson1 apnelson1 requested a review from b-mehta January 29, 2025 21:09
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2025 •
edited
Loading

PR summary b3e34a9c9f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ fundCircuit_diff_eq_inter
+ fundCircuit_eq_of_not_mem_ground
+ fundCircuit_restrict
+ fundCircuit_restrict_univ
- fundCircuit_eq_of_mem'

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jan 29, 2025
b-mehta
b-mehta reviewed Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 29, 2025

✌️ apnelson1 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 29, 2025
@apnelson1
Copy link
Copy Markdown
Collaborator Author

apnelson1 commented Jan 30, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 30, 2025
@apnelson1
feat(Data/Matroid/Circuit): better junk values for fundCircuit (#21240
0cd9763 
)

The definition of fundamental circuits in #21145 was suboptimal, in that its junk values were unstable. We slightly modify the definition so that the fundamental circuit of a non-element `e` of the ground set is a singleton `{e}`. 

This removes assumptions from a couple of existing lemmas, and crucially makes the useful lemma `Matroid.fundCircuit_restrict_univ` true, where it wasn't before.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 30, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Matroid/Circuit): better junk values for fundCircuit [Merged by Bors] - feat(Data/Matroid/Circuit): better junk values for fundCircuit Jan 30, 2025
@mathlib-bors mathlib-bors bot closed this Jan 30, 2025
@mathlib-bors mathlib-bors bot deleted the fundCircuit_junk branch January 30, 2025 01:06
jt496 pushed a commit that referenced this pull request Feb 3, 2025
@apnelson1 @jt496
feat(Data/Matroid/Circuit): better junk values for fundCircuit (#21240
2d5c621 
)

The definition of fundamental circuits in #21145 was suboptimal, in that its junk values were unstable. We slightly modify the definition so that the fundamental circuit of a non-element `e` of the ground set is a singleton `{e}`. 

This removes assumptions from a couple of existing lemmas, and crucially makes the useful lemma `Matroid.fundCircuit_restrict_univ` true, where it wasn't before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b-mehta b-mehta b-mehta left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apnelson1 @b-mehta