[Merged by Bors] - feat(Topology/ContinuousMap/CompactlySupported): add partialOrder#21206
Closed
yoh-tanimoto wants to merge 23 commits intomasterfrom
Closed
[Merged by Bors] - feat(Topology/ContinuousMap/CompactlySupported): add partialOrder#21206yoh-tanimoto wants to merge 23 commits intomasterfrom
partialOrder#21206yoh-tanimoto wants to merge 23 commits intomasterfrom
Conversation
PR summary 77fb1c6fee
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.ContinuousMap.CompactlySupported | 1493 | 1495 | +2 (+0.13%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.MeasureTheory.Integral.RieszMarkovKakutani |
1 |
Mathlib.Topology.ContinuousMap.CompactlySupported |
2 |
Mathlib.Topology.Algebra.Order.Support (new file) |
715 |
Declarations diff
+ HasCompactMulSupport.inf
+ HasCompactMulSupport.sup
+ coe_finsetInf'
+ coe_finsetSup'
+ coe_inf
+ coe_sup
+ finsetInf'_apply
+ finsetSup'_apply
+ inf_apply
+ instInf
+ instSup
+ instance [Lattice β] [TopologicalSpace β] [TopologicalLattice β] [Zero β] :
+ le_def
+ lt_def
+ partialOrder
+ semilatticeInf
+ semilatticeSup
+ sup_apply
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 task
YaelDillies
reviewed
Jan 29, 2025
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Collaborator
Author
|
I thought the lemmas |
YaelDillies
reviewed
Jan 30, 2025
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
reviewed
Jan 31, 2025
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
reviewed
Feb 2, 2025
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
reviewed
Feb 2, 2025
Comment on lines
+20
to
+21
| * We do not put the definitions in the `Function` namespace, following many other topological | ||
| definitions that are in the root namespace (compare `Embedding` vs `Function.Embedding`). |
Contributor
There was a problem hiding this comment.
That's outdated. They are in the Topology namespace. Probably just remove this bullet point entirely (and unbullet the first point (if we even care about it? to_additive is already explained in many places, I don't think we need to duplicate the documentation)
Collaborator
Author
There was a problem hiding this comment.
I removed both points.
Contributor
There was a problem hiding this comment.
I'm fixing the module doc you got that from in #21345
YaelDillies
approved these changes
Feb 2, 2025
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
…21206) Add `instance : PartialOrder C_c(α, β)` using pointwise `PartialOrder β`, following [ContinuousMap.partialOrder](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Topology/ContinuousMap/Ordered.html#ContinuousMap.partialOrder) Co-authored-by: Yoh Tanimoto <57562556+yoh-tanimoto@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
partialOrderpartialOrder
jt496
pushed a commit
that referenced
this pull request
Feb 3, 2025
…21206) Add `instance : PartialOrder C_c(α, β)` using pointwise `PartialOrder β`, following [ContinuousMap.partialOrder](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Topology/ContinuousMap/Ordered.html#ContinuousMap.partialOrder) Co-authored-by: Yoh Tanimoto <57562556+yoh-tanimoto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
instance : PartialOrder C_c(α, β)using pointwisePartialOrder β, following ContinuousMap.partialOrderSplit from #20040