[Merged by Bors] - chore: remove references to _root_.Embedding#21345
Closed
YaelDillies wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore: remove references to _root_.Embedding#21345YaelDillies wants to merge 2 commits intomasterfrom
_root_.Embedding#21345YaelDillies wants to merge 2 commits intomasterfrom
Conversation
This was renamed to `Topology.IsEmbedding`
PR summary e0d30dbc62Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
reviewed
Feb 2, 2025
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
_root_.Embedding_root_.Embedding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was renamed to
Topology.IsEmbeddingin #15993 and #18133 and those docstrings should have been fixed.