[Merged by Bors] - feat(Algebra/Category): ConcreteCategory instance for ModuleCat#21125
Closed
Vierkantor wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - feat(Algebra/Category): ConcreteCategory instance for ModuleCat#21125Vierkantor wants to merge 5 commits intomasterfrom
ConcreteCategory instance for ModuleCat#21125Vierkantor wants to merge 5 commits intomasterfrom
Conversation
This is a step towards a concrete category redesign, as outlined in this Zulip post: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Concrete.20category.20class.20redesign/near/493903980 This PR adds a `ConcreteCategory` instance for `ModuleCat`. It also replaces the `Hom.hom` structure projection with an alias for `ConcreteCategory.hom`. Sadly `ModuleCat.restrictScalars` and `PresheafOfModules` do not appreciate subtle changes in elaboration/defeq, and quite a few declarations need subtle fixes. Maybe a more structural fix exists? I have not tried to look for code that can be cleaned up now, only at what broke. I want to get started on cleanup when the other concrete category instances are in.
PR summary 560ea7a8eaImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 1416 | 1 | erw |
| 12 | 1 | maxHeartBeats modifications |
Current commit 560ea7a8ea
Reference commit 12422efb2d
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Vierkantor
commented
Jan 27, 2025
| dsimp [tensorObjMap] | ||
| simp) | ||
| simp | ||
| rfl) -- `ModuleCat.restrictScalarsId'App_inv_apply` doesn't get picked up due to type mismatch |
Contributor
Author
There was a problem hiding this comment.
This file definitely gets worse off. Haven't figured out a way to make simp use ModuleCat.restrictScalarsId'App_inv_apply: replacing rfl with erw [ModuleCat.restrictScalarsId'App_inv_apply, ModuleCat.restrictScalarsId'App_inv_apply] also solves the goal.
Vierkantor
commented
Jan 27, 2025
| dsimp [map] | ||
| rw [tensorObj_map_tmul] | ||
| -- Need `erw` because of the type mismatch in `map` and the tensor product. | ||
| erw [ModuleCat.MonoidalCategory.tensorHom_tmul, tensorObj_map_tmul] |
Contributor
Author
There was a problem hiding this comment.
Similar story here: there's a type mismatch and we need erw to deal with it.
Vierkantor
commented
Jan 27, 2025
|
|
||
| variable (F : C ⥤ D) | ||
|
|
||
| set_option maxHeartbeats 400000 in -- Seems to be a timeout in type checking the definition |
Contributor
Author
There was a problem hiding this comment.
On my machine, type checking the definition costs 2,5 seconds, about a third of total elaboration time. I haven't been able to trace where all the extra time goes...
Vierkantor
commented
Jan 27, 2025
| obtain ⟨j', i, h⟩ := Concrete.colimit_rep_eq_zero (hx := hx) | ||
| obtain ⟨j'', H⟩ := H | ||
| simpa [elementwise_of% (colimit.w F), this, map_zero] using congr(colimit.ι F _ | ||
| simpa [elementwise_of% (colimit.w F), ← this, map_zero] using congr(colimit.ι F _ |
Contributor
Author
There was a problem hiding this comment.
Flipping the direction of this rewrite actually means getting rid of a few HasForget.instFunLikes!
Contributor
Author
|
!bench |
Contributor
Contributor
Author
|
I'm not sure, since those only provide instances, and don't change general lemmas from |
Contributor
Author
|
But I'll try merging once both are in |
Collaborator
|
Here are the benchmark results for commit b81670f. Benchmark Metric Change
================================================================================
+ ~Mathlib.Algebra.Category.ModuleCat.Biproducts instructions -41.4%
- ~Mathlib.Algebra.Category.ModuleCat.ChangeOfRings instructions 4.2%
+ ~Mathlib.Algebra.Category.ModuleCat.Kernels instructions -48.7%
- ~Mathlib.Algebra.Category.ModuleCat.Monoidal.Closed instructions 27.3%
- ~Mathlib.Algebra.Category.ModuleCat.Presheaf instructions 18.7%
- ~Mathlib.Algebra.Category.ModuleCat.Presheaf.Pushforward instructions 9.5%
+ ~Mathlib.Algebra.Category.ModuleCat.Products instructions -51.1%
+ ~Mathlib.Algebra.Homology.ShortComplex.ModuleCat instructions -32.0%
+ ~Mathlib.AlgebraicGeometry.Modules.Tilde instructions -9.8% |
2 files, Instructions +5.0⬝10⁹
4 files, Instructions +3.0⬝10⁹
4 files, Instructions +2.0⬝10⁹
7 files, Instructions +1.0⬝10⁹
|
Contributor
Author
|
!bench |
Vierkantor
added a commit
that referenced
this pull request
Jan 27, 2025
My script found one `erw` call that could become a `rw`. (This can remain `rw` on #21125 too.)
Vierkantor
added a commit
that referenced
this pull request
Jan 27, 2025
My script found one `erw` call that could become a `rw`. (This can remain `rw` on #21125 too.)
Collaborator
|
Here are the benchmark results for commit 560ea7a. Benchmark Metric Change
================================================================================
+ ~Mathlib.Algebra.Category.ModuleCat.Biproducts instructions -41.2%
- ~Mathlib.Algebra.Category.ModuleCat.ChangeOfRings instructions 4.3%
+ ~Mathlib.Algebra.Category.ModuleCat.Kernels instructions -48.7%
- ~Mathlib.Algebra.Category.ModuleCat.Monoidal.Closed instructions 27.2%
- ~Mathlib.Algebra.Category.ModuleCat.Presheaf.Monoidal instructions 15.7%
- ~Mathlib.Algebra.Category.ModuleCat.Presheaf.Pushforward instructions 8.8%
+ ~Mathlib.Algebra.Category.ModuleCat.Products instructions -51.0%
+ ~Mathlib.Algebra.Homology.ShortComplex.ModuleCat instructions -32.0% |
2 files, Instructions +5.0⬝10⁹
4 files, Instructions +3.0⬝10⁹
4 files, Instructions +2.0⬝10⁹
7 files, Instructions +1.0⬝10⁹
|
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
…21125) This is a step towards a concrete category redesign, as outlined in this Zulip post: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Concrete.20category.20class.20redesign/near/493903980 This PR adds a `ConcreteCategory` instance for `ModuleCat`. It also replaces the `Hom.hom` structure projection with an alias for `ConcreteCategory.hom`. Sadly `ModuleCat.restrictScalars` and `PresheafOfModules` do not appreciate subtle changes in elaboration/defeq, and quite a few declarations need subtle fixes. Maybe a more structural fix exists? I have not tried to look for code that can be cleaned up now, only at what broke. I want to get started on cleanup when the other concrete category instances are in.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
ConcreteCategory instance for ModuleCatConcreteCategory instance for ModuleCat
Julian
added a commit
that referenced
this pull request
Jan 28, 2025
* origin/master: (294 commits) feat: equalizers and coequalizers in the category of ind-objects (#21139) doc: turn more links to Stacks into `@[stacks]` tags (#21135) feat(Asymptotics): prove `IsLittleOTVS.add` (#20578) feat(Algebra/Polynomial): `Polynomial.aeval` for product algebras (#21062) chore: import Std in Mathlib.lean (#21126) feat(Data/Matroid/Circuit): fundamental circuits and extensionality (#21145) feat(CategoryTheory/Endofunctor): prove the dual form of Lambek's Lemma on terminal coalgebra (#21140) feat(SetTheory/Game/PGame): rewrite left moves of `-x` as right moves of `x` under binders (#21109) feat(RingTheory/Localization/Pi): localization of a finite direct product is a product of localizations (#19042) doc: fixed notation error in customizing category composition (#21132) feat(Matrix): more lemmas for `PEquiv.toMatrix` (#21143) chore(SupIndep): speedup the `Decidable` instance (#21114) fix(CI): use `Elab.async=false` for late importers workflow (#21147) feat(Topology/Algebra/Indicator): indicator of a clopen is continuous (#20687) feat(Data/Matroid/Rank/Cardinal): Cardinality-valued rank function (#20921) feat(Algebra): `Pi.single_induction` (#21141) chore(BigOperators/Fin): golf a proof (#21131) feat: generalize tangent cone lemmas to TVS (#20859) feat(CategoryTheory): `Comma.snd L R` is final if `R` is final and domains are filtered (#21136) refactor: unapply matrix lemmas (#21091) chore(Algebra/Category): `erw` -> `rw` (#21130) feat(CategoryTheory): filteredness of Comma catgories given finality of one of the functors (#21128) feat(Algebra/Category): `ConcreteCategory` instance for `ModuleCat` (#21125) feat: PSum of finite sorts is finite (#20285) feat: inequality on the integral of a convex function of a RN derivative (#21093) feat: `(v +ᵥ s) -ᵥ (v +ᵥ t) = s -ᵥ t` (#21058) chore: rename the fact that `(∀ a < a₁, a ≤ a₂) ↔ a₁ ≤ a₂` in a dense order (#20317) feat: a `RelHom` preserves directedness (#20080) feat(Combinatorics/SimpleGraph): add definitions and theorems about the coloring of sum graphs (#18677) chore(Data/Matrix/PEquiv): clean up names (#21108) feat(Algebra/Category): `ConcreteCategory` instances for rings (#20815) feat: define Descriptive.Tree (#18763) chore(Data/Complex/Exponential): split trig functions to new file (#21075) feat(Logic/IsEmpty/Relator): empty on sides (#20319) feat(Algebra/Category): `ConcreteCategory` instance for `AlgebraCat` (#21121) feat(NumberTheory/LSeries): results involving partial sums of coefficients (part 1) (#20661) feat(RingTheory/LaurentSeries): add algebraEquiv (#21004) chore(SetTheory/Game/Impartial): golf two proofs (#21074) feat(CategoryTheory/Subpresheaf): preimage/image/range of subpresheaves (#21047) feat(RingTheory/IntegralClosure): `Algebra.IsIntegral` transfers via surjective homomorphisms (#21023) feat(`InformationTheory/Hamming`): Add AddGroup instances (#20994) feat(RingTheory/IntegralClosure): prove `Module.Finite R (adjoin R S)` for finite set `S` of integral elements (#20970) feat(RingTheory/Artinian): `IsUnit a` iff `a ∈ R⁰` for an artinian ring `R` (#21084) feat: separating set in the category of ind-objects (#21082) feat: derivWithin lemmas (#21092) chore(Fintype): golf a proof (#21113) chore: golf using `funext₂` (#21106) chore(Algebra/Group/Submonoid/Operations): move instances to new file (#21067) doc(Algebra/BigOperators/Fin): change 'product' to 'sum' in doc-string of additivised declarations (#21101) doc(ComputeDegree): typos (#21095) ...
Julian
added a commit
that referenced
this pull request
Feb 1, 2025
* polynomial-sequences: (308 commits) Use the lemma we already added. Minor reordering. This is true even for the trivial ring. Also add the lt versions and the other inj lemma. Also add the basis ne versions. This seems also like it should be simp. Back to sorry free. And the natDegree version. feat: equalizers and coequalizers in the category of ind-objects (#21139) doc: turn more links to Stacks into `@[stacks]` tags (#21135) feat(Asymptotics): prove `IsLittleOTVS.add` (#20578) feat(Algebra/Polynomial): `Polynomial.aeval` for product algebras (#21062) chore: import Std in Mathlib.lean (#21126) feat(Data/Matroid/Circuit): fundamental circuits and extensionality (#21145) feat(CategoryTheory/Endofunctor): prove the dual form of Lambek's Lemma on terminal coalgebra (#21140) feat(SetTheory/Game/PGame): rewrite left moves of `-x` as right moves of `x` under binders (#21109) feat(RingTheory/Localization/Pi): localization of a finite direct product is a product of localizations (#19042) doc: fixed notation error in customizing category composition (#21132) feat(Matrix): more lemmas for `PEquiv.toMatrix` (#21143) chore(SupIndep): speedup the `Decidable` instance (#21114) fix(CI): use `Elab.async=false` for late importers workflow (#21147) feat(Topology/Algebra/Indicator): indicator of a clopen is continuous (#20687) feat(Data/Matroid/Rank/Cardinal): Cardinality-valued rank function (#20921) feat(Algebra): `Pi.single_induction` (#21141) chore(BigOperators/Fin): golf a proof (#21131) feat: generalize tangent cone lemmas to TVS (#20859) feat(CategoryTheory): `Comma.snd L R` is final if `R` is final and domains are filtered (#21136) refactor: unapply matrix lemmas (#21091) chore(Algebra/Category): `erw` -> `rw` (#21130) feat(CategoryTheory): filteredness of Comma catgories given finality of one of the functors (#21128) feat(Algebra/Category): `ConcreteCategory` instance for `ModuleCat` (#21125) feat: PSum of finite sorts is finite (#20285) feat: inequality on the integral of a convex function of a RN derivative (#21093) feat: `(v +ᵥ s) -ᵥ (v +ᵥ t) = s -ᵥ t` (#21058) chore: rename the fact that `(∀ a < a₁, a ≤ a₂) ↔ a₁ ≤ a₂` in a dense order (#20317) feat: a `RelHom` preserves directedness (#20080) feat(Combinatorics/SimpleGraph): add definitions and theorems about the coloring of sum graphs (#18677) chore(Data/Matrix/PEquiv): clean up names (#21108) feat(Algebra/Category): `ConcreteCategory` instances for rings (#20815) feat: define Descriptive.Tree (#18763) chore(Data/Complex/Exponential): split trig functions to new file (#21075) feat(Logic/IsEmpty/Relator): empty on sides (#20319) feat(Algebra/Category): `ConcreteCategory` instance for `AlgebraCat` (#21121) feat(NumberTheory/LSeries): results involving partial sums of coefficients (part 1) (#20661) feat(RingTheory/LaurentSeries): add algebraEquiv (#21004) chore(SetTheory/Game/Impartial): golf two proofs (#21074) feat(CategoryTheory/Subpresheaf): preimage/image/range of subpresheaves (#21047) feat(RingTheory/IntegralClosure): `Algebra.IsIntegral` transfers via surjective homomorphisms (#21023) feat(`InformationTheory/Hamming`): Add AddGroup instances (#20994) feat(RingTheory/IntegralClosure): prove `Module.Finite R (adjoin R S)` for finite set `S` of integral elements (#20970) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step towards a concrete category redesign, as outlined in this Zulip post: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Concrete.20category.20class.20redesign/near/493903980
This PR adds a
ConcreteCategoryinstance forModuleCat. It also replaces theHom.homstructure projection with an alias forConcreteCategory.hom. SadlyModuleCat.restrictScalarsandPresheafOfModulesdo not appreciate subtle changes in elaboration/defeq, and quite a few declarations need subtle fixes. Maybe a more structural fix exists?I have not tried to look for code that can be cleaned up now, only at what broke. I want to get started on cleanup when the other concrete category instances are in.