[Merged by Bors] - chore(Data/Nat/Cast): don't import MonoidWithZero for results about MonoidHom#20745
Closed
YaelDillies wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore(Data/Nat/Cast): don't import MonoidWithZero for results about MonoidHom#20745YaelDillies wants to merge 4 commits intomasterfrom
MonoidWithZero for results about MonoidHom#20745YaelDillies wants to merge 4 commits intomasterfrom
Conversation
PR summary 12ab92d7c5
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Category.MonCat.ForgetCorepresentable | 463 | 457 | -6 (-1.30%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 3644 files with changed transitive imports taking up over 158242 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
2 tasks
9059d19 to
94155e3
Compare
Contributor
|
Did you intentionally duplicate |
MonoidWithZero for results about MonoidHomMonoidWithZero for results about MonoidHom
Contributor
Author
|
What do you mean? I can't see how I've duplicated anything. |
…bout `MonoidHom` For this, move the results from `Data.Nat.Cast.Basic` not mentioning `Nat.cast` (!) to a new file `Algebra.Group.Nat.Hom`. See leanprover-community/mathlib3#2957 for the copyright attribution.
94155e3 to
2603b50
Compare
Contributor
|
You added them in the new file, but they still exist in |
Contributor
Author
|
I am really confused how CI could pass when there were duplicated lemmas. It's not that they were in different namespaces. Importing one file into the next gives an error. |
Ruben-VandeVelde
approved these changes
Jan 24, 2025
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2025
… `MonoidHom` (#20745) For this, move the results from `Data.Nat.Cast.Basic` not mentioning `Nat.cast` (!) to a new file `Algebra.Group.Nat.Hom`. See leanprover-community/mathlib3#2957 for the copyright attribution.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
MonoidWithZero for results about MonoidHomMonoidWithZero for results about MonoidHom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this, move the results from
Data.Nat.Cast.Basicnot mentioningNat.cast(!) to a new fileAlgebra.Group.Nat.Hom.See leanprover-community/mathlib3#2957 for the copyright attribution.