This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Conversation
Member
urkud
commented
Jun 5, 2020
jcommelin
reviewed
Jun 5, 2020
|
|
||
| /-- Two additive monoid homomorphisms `f`, `g` from `ℤ` to an additive monoid are equal | ||
| if `f 1 = g 1`. -/ | ||
| @[ext] theorem ext_int [add_monoid A] {f g : ℤ →+ A} (h1 : f 1 = g 1) : f = g := |
Member
There was a problem hiding this comment.
Should this be done for arbitrary cyclic groups first?
Member
Author
There was a problem hiding this comment.
I would prefer to say something like "the subgroup closure {1} in int is top, so we're done" but data/int/basic is a dependency of submonoid.
Member
There was a problem hiding this comment.
Ok, then we just prove it twice. It's not like it's that much work. I'll review this again. If I have no more comments, we can merge this.
|
Pull request successfully merged into master. Build succeeded: |
add_monoid_hom.ext_nat/intadd_monoid_hom.ext_nat/int
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.