Skip to content

[Merged by Bors] - chore: make uniqueness of conditionally complete linearly ordered archimedean fields independent of the construction of Real#20242

Closed
jcommelin wants to merge 3 commits intomasterfrom
toplevel-alg-anly-2
Closed

[Merged by Bors] - chore: make uniqueness of conditionally complete linearly ordered archimedean fields independent of the construction of Real#20242
jcommelin wants to merge 3 commits intomasterfrom
toplevel-alg-anly-2

Conversation

@jcommelin
Copy link
Copy Markdown
Member

@jcommelin jcommelin commented Dec 25, 2024

Also avoid one import of Analysis/ in Algebra/.

Co-authored-by: Junyan Xu junyanxumath@gmail.com


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 25, 2024

PR summary 739e03ba27

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.CompleteField 1545 631 -914 (-59.16%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Order.CompleteField -914
Mathlib.Data.Real.CompleteField (new file) 1205

Declarations diff

+ abs_pow_sub_pow_le
+ exists_pow_btwn
+ uniform_continuous_npow_on_bounded
- exists_rat_pow_btwn_rat_aux

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alreadydone
Copy link
Copy Markdown
Contributor

I think the title is a bit too vague; is this eliminating the last appearance of Analysis/ in Algebra/? This also doesn't have much of a global effect, as it reduces only the number of transitive imports of one file.

@jcommelin jcommelin changed the title chore: avoid importing Analysis/ in Algebra/ chore: avoid one import of Analysis/ in Algebra/ Jan 2, 2025
@jcommelin jcommelin added t-analysis Analysis (normed *, calculus) t-algebra Algebra (groups, rings, fields, etc) labels Jan 2, 2025
@eric-wieser
Copy link
Copy Markdown
Member

This also doesn't have much of a global effect, as it reduces only the number of transitive imports of one file.

Indeed, as Mathlib.Algebra.Order.CompleteField is not used anywhere. I suppose we could have also "removed the last appearance of Analysis/ in Algebra/" by renaming the file to be in Analysis..

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jan 4, 2025

Please change the title.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 4, 2025

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 4, 2025
@jcommelin jcommelin changed the title chore: avoid one import of Analysis/ in Algebra/ chore: make uniqueness of conditionally complete linearly ordered archimedean fields independent of the construction of Real Jan 4, 2025
@jcommelin
Copy link
Copy Markdown
Member Author

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 4, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 4, 2025
…himedean fields independent of the construction of `Real` (#20242)

Also avoid one import of `Analysis/` in `Algebra/`.

Co-authored-by: Junyan Xu <junyanxumath@gmail.com>



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 4, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: make uniqueness of conditionally complete linearly ordered archimedean fields independent of the construction of Real [Merged by Bors] - chore: make uniqueness of conditionally complete linearly ordered archimedean fields independent of the construction of Real Jan 4, 2025
@mathlib-bors mathlib-bors bot closed this Jan 4, 2025
@mathlib-bors mathlib-bors bot deleted the toplevel-alg-anly-2 branch January 4, 2025 14:32
Julian added a commit that referenced this pull request Jan 5, 2025
* origin/master: (133 commits)
  chore(1000): remove nonexistent fields (#20493)
  chore(CategoryTheory/Adjunction.Basic, CategoryTheory/Equivalence): change definition of `Adjunction.comp` and `Equivalence.trans` (#20490)
  feat(Asymptotics): add `Asymptotics.*.*Prod` lemmas (#20458)
  feat: a conditional kernel is almost everywhere a probability measure (#20430)
  feat: if `f` is a measurable group hom, then every point has a neighborhood `s` such that `f '' s` is bounded (#20304)
  feat: `Ico`, `Ioc`, and `Ioo` are not closed or compact (#20479)
  chore: drop redundant hypothesis in `Module.Dual.eq_of_preReflection_mapsTo` (#20492)
  feat(FaaDiBruno): derive `DecidableEq` (#20482)
  chore(SetTheory/Ordinal/Basic): `{x // x < y}` → `Iio y` (#20413)
  chore: generalize `FormalMultilinearSeries.ofScalars_norm` to `Seminormed` (#20351)
  chore(MvPolynomial/Localization): golf using TensorProduct (#20309)
  chore(Combinatorics/Enumerative/Partition): auto-derive DecidableEq (#20277)
  chore(CategoryTheory): make relevant parameters explicit in `Arrow.homMk`. (#20259)
  feat: add `IsStarNormal (↑x⁻¹ : R)` instance for `x : Rˣ` (#20091)
  fix: Stop cancelling builds of master (#20435)
  chore: update Mathlib dependencies 2025-01-05 (#20485)
  feat(SetTheory/Cardinal/Arithmetic): miscellaneous cardinality lemmas (#18933)
  chore: bump toolchain to v4.16.0-rc1, and merge bump/v4.16.0 (#20464)
  chore: bot validates lean-toolchain on bump/v4.X.0 branches (#20478)
  feat: shorthand lemmas for the L1 norm (#20383)
  chore: remove unnecessary adaptation notes (#20467)
  chore(Algebra/Category/MonCat/Colimits): remove smallness condition (#20473)
  chore(SetTheory/Ordinal/Arithmetic): `IsLeftCancelAdd Ordinal` (#19888)
  feat(Algebra): more on `OrthogonalIdempotents` (#18195)
  feat(Radical): `(radical a).natDegree ≤ a.natDegree` (#20468)
  feat(Polynomial): `(a^n)' = 0` iff `a' = 0` when `n` doesn't divide the characteristic (#20190)
  feat(Algebra/Lie): add Lie's theorem (#13480)
  chore(RingTheory/Generators): make algebra instance a def (#14265)
  feat(Topology/Group): Lemmas about profinite group (#20282)
  feat: the empty set is a topological basis iff the space is empty (#20441)
  chore: make uniqueness of conditionally complete linearly ordered archimedean fields independent of the construction of `Real` (#20242)
  chore: `inherit_doc`s for notations (#20376)
  chore: split AEEqOfIntegral into two files, one for each integral type (#20405)
  chore: split Kernel/MeasurableIntegral (#20427)
  feat(MeasureTheory/Group/Measure): add ContinuousMulEquiv.isHaarMeasure_map (#20469)
  fix(Mathlib.Tactic.CC.Datatypes): `cc` raises panic (#20422)
  feat(Probability/Moments): add lemmas about moment generating functions (#19886)
  feat(Algebra/Order/AddGroupWithTop): lemmas about LinearOrderedAddCommGroupWithTop (#18954)
  chore: bump toolchain to v4.15.0 (#20461)
  chore: update Mathlib dependencies 2025-01-04 (#20463)
  fix: make `Prod` projection delaborators respond to options, add option to disable (#20455)
  chore(Algebra): Improve attribute generation (#20451)
  feat(Polynomial): `(C a * p).degree = p.degree` if `a * p.leadingCoeff ≠ 0` (#20446)
  feat: add `ENNReal.finStronglyMeasurable_of_measurable` (#20404)
  doc(Algebra/Lie/Weights/Basic): fix typo (#20450)
  chore(1000): remove `identifiers` (#20445)
  feat: add sumPiEquivProdPi and piUnique (#20195)
  feat: add fst_compProd_apply (#20429)
  chore: use unsigned measures for Lebesgue decomposition (#20400)
  feat: Two lemmas on divisibility and coprimality of `expand` (#20143)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants