Skip to content

[Merged by Bors] - feat: add sumPiEquivProdPi and piUnique#20195

Closed
kbuzzard wants to merge 17 commits intomasterfrom
kbuzzard-pUnitPiEquiv
Closed

[Merged by Bors] - feat: add sumPiEquivProdPi and piUnique#20195
kbuzzard wants to merge 17 commits intomasterfrom
kbuzzard-pUnitPiEquiv

Conversation

@kbuzzard
Copy link
Copy Markdown
Member

@kbuzzard kbuzzard commented Dec 23, 2024

From FLT. Add topological and algebraic versions of Equiv.sumPiEquivProdPi and Equiv.piUnique.


Open in Gitpod

@kbuzzard kbuzzard added the t-algebra Algebra (groups, rings, fields, etc) label Dec 23, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 23, 2024

PR summary 1d7b7d4d6c

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Module.Equiv.Basic 461 463 +2 (+0.43%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Lie.NonUnitalNonAssocAlgebra Mathlib.Algebra.Algebra.NonUnitalHom 1
202 files Mathlib.CategoryTheory.Galois.IsFundamentalgroup Mathlib.CategoryTheory.Preadditive.Yoneda.Projective Mathlib.Algebra.Polynomial.Degree.Support Mathlib.AlgebraicTopology.DoldKan.EquivalencePseudoabelian Mathlib.LinearAlgebra.Countable Mathlib.Data.Nat.Choose.Cast Mathlib.AlgebraicTopology.DoldKan.SplitSimplicialObject Mathlib.CategoryTheory.Abelian.RightDerived Mathlib.CategoryTheory.Abelian.DiagramLemmas.Four Mathlib.Algebra.Polynomial.Degree.Definitions Mathlib.Algebra.Polynomial.Degree.Operations Mathlib.Algebra.Homology.Opposite Mathlib.Topology.Algebra.UniformField Mathlib.CategoryTheory.Adjunction.Additive Mathlib.LinearAlgebra.SModEq Mathlib.Algebra.Homology.DerivedCategory.HomologySequence Mathlib.Algebra.Homology.ShortComplex.SnakeLemma Mathlib.LinearAlgebra.Finsupp.Supported Mathlib.Algebra.Polynomial.Degree.Monomial Mathlib.Algebra.Homology.Embedding.HomEquiv Mathlib.RingTheory.Polynomial.Pochhammer Mathlib.Algebra.Homology.Embedding.IsSupported Mathlib.CategoryTheory.Limits.ConcreteCategory.WithAlgebraicStructures Mathlib.CategoryTheory.Abelian.Transfer Mathlib.Algebra.Polynomial.Eval.Irreducible Mathlib.CategoryTheory.Galois.GaloisObjects Mathlib.Algebra.Module.Equiv.Basic Mathlib.CategoryTheory.Preadditive.Yoneda.Basic Mathlib.CategoryTheory.Abelian.EpiWithInjectiveKernel Mathlib.Algebra.Polynomial.HasseDeriv Mathlib.Algebra.Homology.HomotopyCategory.Pretriangulated Mathlib.AlgebraicTopology.DoldKan.Homotopies Mathlib.CategoryTheory.Action.Limits Mathlib.RingTheory.Polynomial.Opposites Mathlib.CategoryTheory.Abelian.Opposite Mathlib.MeasureTheory.Constructions.AddChar Mathlib.Algebra.Homology.DerivedCategory.Ext.Basic Mathlib.Algebra.Homology.ShortComplex.HomologicalComplex Mathlib.Algebra.Homology.HomotopyCategory.HomComplexShift Mathlib.Topology.Algebra.Nonarchimedean.Completion Mathlib.Algebra.Homology.HomotopyCategory.MappingCone Mathlib.NumberTheory.ClassNumber.AdmissibleAbs Mathlib.Data.Finsupp.Weight Mathlib.RingTheory.Polynomial.Hermite.Basic Mathlib.Algebra.Homology.TotalComplexShift Mathlib.CategoryTheory.Abelian.ProjectiveResolution Mathlib.Algebra.MonoidAlgebra.Support Mathlib.Algebra.MonoidAlgebra.NoZeroDivisors Mathlib.LinearAlgebra.GeneralLinearGroup Mathlib.Algebra.Polynomial.Inductions Mathlib.CategoryTheory.Localization.CalculusOfFractions.Preadditive Mathlib.Algebra.Polynomial.DenomsClearable Mathlib.Algebra.Algebra.Basic Mathlib.Algebra.Polynomial.Eval.Algebra Mathlib.CategoryTheory.Sites.Abelian Mathlib.CategoryTheory.Triangulated.Opposite.Functor Mathlib.Algebra.Category.MonCat.Limits Mathlib.Algebra.Lie.Basic Mathlib.AlgebraicTopology.DoldKan.GammaCompN Mathlib.CategoryTheory.Abelian.GrothendieckAxioms.Sheaf Mathlib.CategoryTheory.Triangulated.Opposite.Pretriangulated Mathlib.Algebra.Group.AddChar Mathlib.Algebra.Algebra.Hom.Rat Mathlib.LinearAlgebra.Finsupp.LSum Mathlib.CategoryTheory.Triangulated.HomologicalFunctor Mathlib.Algebra.Homology.HomotopyCategory.HomologicalFunctor Mathlib.CategoryTheory.Shift.ShiftedHomOpposite Mathlib.CategoryTheory.Triangulated.Opposite.Triangle Mathlib.Algebra.Algebra.Opposite Mathlib.CategoryTheory.Action.Monoidal Mathlib.Algebra.Homology.HomotopyCategory.Triangulated Mathlib.Algebra.Small.Module Mathlib.LinearAlgebra.Finsupp.LinearCombination Mathlib.Algebra.Polynomial.Mirror Mathlib.Algebra.Equiv.TransferInstance Mathlib.Algebra.Homology.HomotopyCategory.SingleFunctors Mathlib.CategoryTheory.Abelian.Refinements Mathlib.Algebra.MonoidAlgebra.Degree Mathlib.Algebra.Polynomial.Degree.SmallDegree Mathlib.Algebra.Algebra.Pi Mathlib.Algebra.Category.Grp.FilteredColimits Mathlib.Algebra.Polynomial.Monic Mathlib.Algebra.Polynomial.Degree.Domain Mathlib.Data.Nat.Choose.Vandermonde Mathlib.CategoryTheory.Generator.Abelian Mathlib.Algebra.Polynomial.Coeff Mathlib.CategoryTheory.Monoidal.Tor Mathlib.Algebra.Homology.Embedding.Extend Mathlib.Algebra.Category.Ring.FilteredColimits Mathlib.CategoryTheory.Galois.Decomposition Mathlib.Algebra.Homology.HomotopyCategory.HomComplex Mathlib.Tactic.ComputeDegree Mathlib.Geometry.RingedSpace.Basic Mathlib.Algebra.Small.Ring Mathlib.CategoryTheory.Galois.Basic Mathlib.Algebra.Homology.DerivedCategory.SingleTriangle Mathlib.AlgebraicTopology.DoldKan.EquivalenceAdditive Mathlib.Algebra.Homology.DerivedCategory.ShortExact Mathlib.Algebra.Homology.HomotopyCategory.Shift Mathlib.Algebra.Homology.ShortComplex.Linear Mathlib.CategoryTheory.Shift.Opposite Mathlib.AlgebraicTopology.DoldKan.HomotopyEquivalence Mathlib.Computability.TMComputable Mathlib.Algebra.Category.ModuleCat.FilteredColimits Mathlib.CategoryTheory.Generator.Preadditive Mathlib.CategoryTheory.Abelian.GrothendieckAxioms.FunctorCategory Mathlib.Algebra.Category.ModuleCat.Colimits Mathlib.CategoryTheory.Galois.Topology Mathlib.Algebra.Polynomial.Derivative Mathlib.Algebra.Small.Group Mathlib.Topology.Algebra.UniformRing Mathlib.Algebra.Category.Grp.Ulift Mathlib.AlgebraicTopology.DoldKan.Notations Mathlib.Algebra.Homology.Refinements Mathlib.Algebra.Polynomial.Eval.Degree Mathlib.AlgebraicTopology.DoldKan.Normalized Mathlib.CategoryTheory.Galois.Full Mathlib.Algebra.Category.ModuleCat.Basic Mathlib.Algebra.Polynomial.Eval.SMul Mathlib.CategoryTheory.Localization.Triangulated Mathlib.CategoryTheory.Galois.Prorepresentability Mathlib.AlgebraicTopology.DoldKan.Faces Mathlib.Algebra.Homology.Localization Mathlib.Algebra.Homology.ShortComplex.Preadditive Mathlib.Algebra.Homology.BifunctorHomotopy Mathlib.Algebra.Homology.ShortComplex.Exact Mathlib.AlgebraicTopology.DoldKan.Equivalence Mathlib.Algebra.DirectSum.AddChar Mathlib.AlgebraicTopology.DoldKan.Decomposition Mathlib.Algebra.Category.Grp.ZModuleEquivalence Mathlib.Algebra.Homology.SingleHomology Mathlib.AlgebraicTopology.DoldKan.PInfty Mathlib.Algebra.Polynomial.BigOperators Mathlib.Algebra.Category.Ring.Limits Mathlib.AlgebraicTopology.DoldKan.FunctorGamma Mathlib.CategoryTheory.Abelian.GrothendieckAxioms.Basic Mathlib.Algebra.Homology.HomologySequenceLemmas Mathlib.Algebra.Polynomial.Reverse Mathlib.CategoryTheory.Preadditive.ProjectiveResolution Mathlib.Algebra.Polynomial.Eval.Defs Mathlib.Algebra.Homology.HomologicalComplexAbelian Mathlib.Algebra.Category.MonCat.FilteredColimits Mathlib.CategoryTheory.Abelian.Exact Mathlib.Algebra.Homology.QuasiIso Mathlib.AlgebraicTopology.DoldKan.NCompGamma Mathlib.Algebra.Homology.HomotopyCategory.ShiftSequence Mathlib.CategoryTheory.Triangulated.Opposite.Basic Mathlib.CategoryTheory.Preadditive.Opposite Mathlib.Algebra.Category.Grp.Limits Mathlib.AlgebraicTopology.ExtraDegeneracy Mathlib.CategoryTheory.Galois.Examples Mathlib.Data.Finsupp.MonomialOrder.DegLex Mathlib.Algebra.MonoidAlgebra.Division Mathlib.Algebra.Polynomial.Eval.Coeff Mathlib.Algebra.Homology.HomotopyCategory.ShortExact Mathlib.CategoryTheory.Triangulated.Subcategory Mathlib.Algebra.Polynomial.Degree.Lemmas Mathlib.CategoryTheory.Abelian.InjectiveResolution Mathlib.Algebra.Polynomial.Monomial Mathlib.CategoryTheory.Abelian.GrothendieckCategory Mathlib.Data.Nat.Factorial.Cast Mathlib.Algebra.Category.Grp.Biproducts Mathlib.CategoryTheory.Preadditive.InjectiveResolution Mathlib.Algebra.Homology.ExactSequence Mathlib.CategoryTheory.Galois.Action Mathlib.AlgebraicTopology.AlternatingFaceMapComplex Mathlib.CategoryTheory.Abelian.LeftDerived Mathlib.Algebra.Homology.Homotopy Mathlib.Algebra.Polynomial.UnitTrinomial Mathlib.Algebra.Algebra.Equiv Mathlib.Algebra.Polynomial.Basic Mathlib.Algebra.MonoidAlgebra.Defs Mathlib.Algebra.Homology.HomotopyCofiber Mathlib.Algebra.Polynomial.CancelLeads Mathlib.Algebra.Algebra.Hom Mathlib.CategoryTheory.Galois.EssSurj Mathlib.CategoryTheory.Linear.Yoneda Mathlib.Algebra.Homology.HomologySequence Mathlib.Algebra.Polynomial.EraseLead Mathlib.Algebra.Polynomial.Degree.Units Mathlib.Algebra.Homology.ShortComplex.ShortExact Mathlib.LinearAlgebra.FiniteSpan Mathlib.Algebra.Polynomial.Eval.Subring Mathlib.Algebra.Homology.HomotopyCategory Mathlib.Algebra.Homology.HomotopyCategory.DegreewiseSplit Mathlib.Topology.Algebra.InfiniteSum.Nonarchimedean Mathlib.Algebra.Polynomial.Degree.TrailingDegree Mathlib.AlgebraicTopology.DoldKan.FunctorN Mathlib.Algebra.Homology.BifunctorShift Mathlib.Algebra.Polynomial.Cardinal Mathlib.Algebra.Homology.ShortComplex.ExactFunctor Mathlib.Algebra.Homology.Embedding.StupidTrunc Mathlib.Algebra.Homology.DerivedCategory.Basic Mathlib.Algebra.Homology.Factorizations.Basic Mathlib.Algebra.Homology.DerivedCategory.ExactFunctor Mathlib.Algebra.Homology.Embedding.ExtendHomology Mathlib.AlgebraicTopology.DoldKan.NReflectsIso Mathlib.Algebra.Polynomial.Div Mathlib.Algebra.Homology.DerivedCategory.Ext.ExtClass Mathlib.AlgebraicTopology.DoldKan.Degeneracies Mathlib.AlgebraicTopology.DoldKan.Projections Mathlib.Algebra.Homology.Embedding.TruncGE
2

Declarations diff

+ Equiv.continuous_symm_iff
+ Equiv.isOpenMap_symm_iff
+ piCongrLeft
+++ piUnique
+++ sumPiEquivProdPi

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 23, 2024

✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 23, 2024
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably these should have @[simps], especially if the existing weaker ones in mathlib do.

@kbuzzard
Copy link
Copy Markdown
Member Author

kbuzzard commented Dec 25, 2024

I don't really want to merge this at the moment because of this unexpected twist where a continuity proof that was by fun_prop now involves a random new declaration Equiv.continuous_symm_of_isOpenMap which we may even have in some other form already.

In other words: this PR has had a new declaration added since it was delegated so I'm reluctant to go ahead with the merge until someone else signs it off.

@kbuzzard kbuzzard removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 28, 2024
kbuzzard and others added 2 commits January 3, 2025 08:30
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@kbuzzard kbuzzard changed the title feat: add sumPiEquivProdPi and pUnitPiEquiv feat: add sumPiEquivProdPi and piUnique Jan 3, 2025
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 3, 2025

✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 3, 2025
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@kbuzzard
Copy link
Copy Markdown
Member Author

kbuzzard commented Jan 3, 2025

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 3, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 3, 2025
From FLT. Add topological and algebraic versions of `Equiv.sumPiEquivProdPi` and `Equiv.piUnique`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 3, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add sumPiEquivProdPi and piUnique [Merged by Bors] - feat: add sumPiEquivProdPi and piUnique Jan 3, 2025
@mathlib-bors mathlib-bors bot closed this Jan 3, 2025
@mathlib-bors mathlib-bors bot deleted the kbuzzard-pUnitPiEquiv branch January 3, 2025 17:41
Julian added a commit that referenced this pull request Jan 5, 2025
* origin/master: (133 commits)
  chore(1000): remove nonexistent fields (#20493)
  chore(CategoryTheory/Adjunction.Basic, CategoryTheory/Equivalence): change definition of `Adjunction.comp` and `Equivalence.trans` (#20490)
  feat(Asymptotics): add `Asymptotics.*.*Prod` lemmas (#20458)
  feat: a conditional kernel is almost everywhere a probability measure (#20430)
  feat: if `f` is a measurable group hom, then every point has a neighborhood `s` such that `f '' s` is bounded (#20304)
  feat: `Ico`, `Ioc`, and `Ioo` are not closed or compact (#20479)
  chore: drop redundant hypothesis in `Module.Dual.eq_of_preReflection_mapsTo` (#20492)
  feat(FaaDiBruno): derive `DecidableEq` (#20482)
  chore(SetTheory/Ordinal/Basic): `{x // x < y}` → `Iio y` (#20413)
  chore: generalize `FormalMultilinearSeries.ofScalars_norm` to `Seminormed` (#20351)
  chore(MvPolynomial/Localization): golf using TensorProduct (#20309)
  chore(Combinatorics/Enumerative/Partition): auto-derive DecidableEq (#20277)
  chore(CategoryTheory): make relevant parameters explicit in `Arrow.homMk`. (#20259)
  feat: add `IsStarNormal (↑x⁻¹ : R)` instance for `x : Rˣ` (#20091)
  fix: Stop cancelling builds of master (#20435)
  chore: update Mathlib dependencies 2025-01-05 (#20485)
  feat(SetTheory/Cardinal/Arithmetic): miscellaneous cardinality lemmas (#18933)
  chore: bump toolchain to v4.16.0-rc1, and merge bump/v4.16.0 (#20464)
  chore: bot validates lean-toolchain on bump/v4.X.0 branches (#20478)
  feat: shorthand lemmas for the L1 norm (#20383)
  chore: remove unnecessary adaptation notes (#20467)
  chore(Algebra/Category/MonCat/Colimits): remove smallness condition (#20473)
  chore(SetTheory/Ordinal/Arithmetic): `IsLeftCancelAdd Ordinal` (#19888)
  feat(Algebra): more on `OrthogonalIdempotents` (#18195)
  feat(Radical): `(radical a).natDegree ≤ a.natDegree` (#20468)
  feat(Polynomial): `(a^n)' = 0` iff `a' = 0` when `n` doesn't divide the characteristic (#20190)
  feat(Algebra/Lie): add Lie's theorem (#13480)
  chore(RingTheory/Generators): make algebra instance a def (#14265)
  feat(Topology/Group): Lemmas about profinite group (#20282)
  feat: the empty set is a topological basis iff the space is empty (#20441)
  chore: make uniqueness of conditionally complete linearly ordered archimedean fields independent of the construction of `Real` (#20242)
  chore: `inherit_doc`s for notations (#20376)
  chore: split AEEqOfIntegral into two files, one for each integral type (#20405)
  chore: split Kernel/MeasurableIntegral (#20427)
  feat(MeasureTheory/Group/Measure): add ContinuousMulEquiv.isHaarMeasure_map (#20469)
  fix(Mathlib.Tactic.CC.Datatypes): `cc` raises panic (#20422)
  feat(Probability/Moments): add lemmas about moment generating functions (#19886)
  feat(Algebra/Order/AddGroupWithTop): lemmas about LinearOrderedAddCommGroupWithTop (#18954)
  chore: bump toolchain to v4.15.0 (#20461)
  chore: update Mathlib dependencies 2025-01-04 (#20463)
  fix: make `Prod` projection delaborators respond to options, add option to disable (#20455)
  chore(Algebra): Improve attribute generation (#20451)
  feat(Polynomial): `(C a * p).degree = p.degree` if `a * p.leadingCoeff ≠ 0` (#20446)
  feat: add `ENNReal.finStronglyMeasurable_of_measurable` (#20404)
  doc(Algebra/Lie/Weights/Basic): fix typo (#20450)
  chore(1000): remove `identifiers` (#20445)
  feat: add sumPiEquivProdPi and piUnique (#20195)
  feat: add fst_compProd_apply (#20429)
  chore: use unsigned measures for Lebesgue decomposition (#20400)
  feat: Two lemmas on divisibility and coprimality of `expand` (#20143)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants