Skip to content

[Merged by Bors] - chore: backport fixes for leanprover/lean4#6397#20097

Closed
kim-em wants to merge 3 commits intomasterfrom
6397_backports
Closed

[Merged by Bors] - chore: backport fixes for leanprover/lean4#6397#20097
kim-em wants to merge 3 commits intomasterfrom
6397_backports

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Dec 20, 2024

These fixes are all of the form "a terminal simp only which was unnecessarily fragile", i.e., can be replaced by a simp that works both on v4.15.0-rc1 and under leanprover/lean4#6397.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 20, 2024

PR summary 0877ca507b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@tb65536
Copy link
Copy Markdown
Contributor

tb65536 commented Dec 20, 2024

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by tb65536.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 20, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 20, 2024
These fixes are all of the form "a terminal simp only which was unnecessarily fragile", i.e., can be replaced by a `simp` that works both on `v4.15.0-rc1` and under leanprover/lean4#6397.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: backport fixes for leanprover/lean4#6397 [Merged by Bors] - chore: backport fixes for leanprover/lean4#6397 Dec 20, 2024
@mathlib-bors mathlib-bors bot closed this Dec 20, 2024
@mathlib-bors mathlib-bors bot deleted the 6397_backports branch December 20, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants