fix: ensure simp and dsimp do not unfold too much#6397
Merged
Conversation
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 16, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 16, 2024
|
Mathlib CI status (docs):
|
If `foo` is tagged as `[irreducible]`, `simp [foo]` must not delta reduce `foo`, and should rely exclusively on the equation lemmas for `foo`. Mathlib relies on this behavior to implement the command `irreducible_def`.
488591f to
b2deb05
Compare
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 20, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 20, 2024
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 20, 2024
These fixes are all of the form "a terminal simp only which was unnecessarily fragile", i.e., can be replaced by a `simp` that works both on `v4.15.0-rc1` and under leanprover/lean4#6397.
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Johan Commelin <johan@commelin.net>
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Johan Commelin <johan@commelin.net>
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Johan Commelin <johan@commelin.net>
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Johan Commelin <johan@commelin.net>
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Johan Commelin <johan@commelin.net>
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Jan 21, 2025
This PR ensures that `simp` and `dsimp` do not unfold definitions that are not intended to be unfolded by the user. See issue leanprover#5755 for an example affected by this issue. Closes leanprover#5755 --------- Co-authored-by: Kim Morrison <kim@tqft.net>
JovanGerb
pushed a commit
to JovanGerb/lean4
that referenced
this pull request
Jan 21, 2025
This PR ensures that `simp` and `dsimp` do not unfold definitions that are not intended to be unfolded by the user. See issue leanprover#5755 for an example affected by this issue. Closes leanprover#5755 --------- Co-authored-by: Kim Morrison <kim@tqft.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that
simpanddsimpdo not unfold definitions that are not intended to be unfolded by the user. See issue #5755 for an example affected by this issue.Closes #5755